2023-06-29 14:42:21

by Like Xu

Subject: [PATCH] KVM: selftests: Fix the meta info of test cases in the header comments

From: Like Xu <[email protected]>

Fix test case names (including descriptions) in comments for
tsc_scaling_sync and xen_shinfo_test. No functional changes intended.

Fixes: e467b0de82b2 ("KVM: x86: Test case for TSC scaling and offset sync")
Fixes: 8d4e7e80838f ("KVM: x86: declare Xen HVM shared info capability and add test case")
Signed-off-by: Like Xu <[email protected]>
---
tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c | 4 ++--
tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c b/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
index 5b669818e39a..cdb214660e0a 100644
--- a/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
+++ b/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
@@ -1,10 +1,10 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * svm_vmcall_test
+ * tsc_scaling_sync
*
* Copyright © 2021 Amazon.com, Inc. or its affiliates.
*
- * Xen shared_info / pvclock testing
+ * Test case for TSC scaling and offset sync
*/

#include "test_util.h"
diff --git a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
index 05898ad9f4d9..60daee9f3514 100644
--- a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
+++ b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * svm_vmcall_test
+ * xen_shinfo_test
*
* Copyright © 2021 Amazon.com, Inc. or its affiliates.
*

base-commit: 88bb466c9dec4f70d682cf38c685324e7b1b3d60
--
2.32.0

2023-06-29 16:01:17

by Sean Christopherson

Subject: Re: [PATCH] KVM: selftests: Fix the meta info of test cases in the header comments

On Thu, Jun 29, 2023, Like Xu wrote:
> From: Like Xu <[email protected]>
>
> Fix test case names (including descriptions) in comments for
> tsc_scaling_sync and xen_shinfo_test. No functional changes intended.
>
> Fixes: e467b0de82b2 ("KVM: x86: Test case for TSC scaling and offset sync")
> Fixes: 8d4e7e80838f ("KVM: x86: declare Xen HVM shared info capability and add test case")
> Signed-off-by: Like Xu <[email protected]>
> ---
> tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c | 4 ++--
> tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c b/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> index 5b669818e39a..cdb214660e0a 100644
> --- a/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> +++ b/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> @@ -1,10 +1,10 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * svm_vmcall_test
> + * tsc_scaling_sync
> *
> * Copyright � 2021 Amazon.com, Inc. or its affiliates.
> *
> - * Xen shared_info / pvclock testing
> + * Test case for TSC scaling and offset sync

I vote to delete the metadata (but leave the Copyright). IMO it adds zero value,
and has a non-zero chance of becoming stale in the future.

> */
>
> #include "test_util.h"
> diff --git a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> index 05898ad9f4d9..60daee9f3514 100644
> --- a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * svm_vmcall_test
> + * xen_shinfo_test
> *
> * Copyright � 2021 Amazon.com, Inc. or its affiliates.
> *
>
> base-commit: 88bb466c9dec4f70d682cf38c685324e7b1b3d60
> --
> 2.32.0
>