2023-07-01 08:11:57

by dengxiang

Subject: [PATCH v4] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760

These models use NSIWAY amplifiers for internal speaker, but cannot put
sound outside from these amplifiers. So eapd verbs are needed to initialize
the amplifiers. They can be added during boot to get working sound out
of internal speaker.

---
V4:
- put at the right position to keep the PCI SSID order for the whole.
V3:
- do some adjustment for eapd verbs and keep the capital letters for
ALC_* enums.
v2:
- remove warning about unused variable 'spec'.

Signed-off-by: dengxiang <[email protected]>
---
sound/pci/hda/patch_realtek.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index afe8253f9a4f..20b10b996fc2 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11286,6 +11286,7 @@ enum {
ALC897_FIXUP_HP_HSMIC_VERB,
ALC897_FIXUP_LENOVO_HEADSET_MODE,
ALC897_FIXUP_HEADSET_MIC_PIN2,
+ ALC897_FIXUP_UNIS_H3C_X500S,
};

static const struct hda_fixup alc662_fixups[] = {
@@ -11725,6 +11726,13 @@ static const struct hda_fixup alc662_fixups[] = {
.chained = true,
.chain_id = ALC897_FIXUP_LENOVO_HEADSET_MODE
},
+ [ALC897_FIXUP_UNIS_H3C_X500S] = {
+ .type = HDA_FIXUP_VERBS,
+ .v.verbs = (const struct hda_verb[]) {
+ { 0x14, AC_VERB_SET_EAPD_BTLENABLE, 0 },
+ {}
+ },
+ },
};

static const struct snd_pci_quirk alc662_fixup_tbl[] = {
@@ -11772,6 +11780,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1bf3, "ASUS N76VZ", ALC662_FIXUP_BASS_MODE4_CHMAP),
SND_PCI_QUIRK(0x1043, 0x8469, "ASUS mobo", ALC662_FIXUP_NO_JACK_DETECT),
SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_FIXUP_ASUS_MODE2),
+ SND_PCI_QUIRK(0x10ec, 0x0897, "UNIS H3C X500S", ALC897_FIXUP_UNIS_H3C_X500S),
SND_PCI_QUIRK(0x144d, 0xc051, "Samsung R720", ALC662_FIXUP_IDEAPAD),
SND_PCI_QUIRK(0x14cd, 0x5003, "USI", ALC662_FIXUP_USI_HEADSET_MODE),
SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC662_FIXUP_LENOVO_MULTI_CODECS),
@@ -11886,6 +11895,7 @@ static const struct hda_model_fixup alc662_fixup_models[] = {
{.id = ALC662_FIXUP_USI_HEADSET_MODE, .name = "usi-headset"},
{.id = ALC662_FIXUP_LENOVO_MULTI_CODECS, .name = "dual-codecs"},
{.id = ALC669_FIXUP_ACER_ASPIRE_ETHOS, .name = "aspire-ethos"},
+ {.id = ALC897_FIXUP_UNIS_H3C_X500S, .name = "unis-h3c-x500s"},
{}
};

--
2.30.2

2023-07-02 08:12:51

by Takashi Iwai

Subject: Re: [PATCH v4] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760

On Sat, 01 Jul 2023 10:04:30 +0200,
dengxiang wrote:
>
> These models use NSIWAY amplifiers for internal speaker, but cannot put
> sound outside from these amplifiers. So eapd verbs are needed to initialize
> the amplifiers. They can be added during boot to get working sound out
> of internal speaker.
>
> ---
> V4:
> - put at the right position to keep the PCI SSID order for the whole.
> V3:
> - do some adjustment for eapd verbs and keep the capital letters for
> ALC_* enums.
> v2:
> - remove warning about unused variable 'spec'.
>
> Signed-off-by: dengxiang <[email protected]>

Signed-off-by tag must be put before the line '---'.
But, above all....

> @@ -11772,6 +11780,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1043, 0x1bf3, "ASUS N76VZ", ALC662_FIXUP_BASS_MODE4_CHMAP),
> SND_PCI_QUIRK(0x1043, 0x8469, "ASUS mobo", ALC662_FIXUP_NO_JACK_DETECT),
> SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_FIXUP_ASUS_MODE2),
> + SND_PCI_QUIRK(0x10ec, 0x0897, "UNIS H3C X500S", ALC897_FIXUP_UNIS_H3C_X500S),

Now I noticed that 10ec is a generic vendor id for Realtek, so it's
not really specific to your device. It implies that your BIOS is
still not mature.

I'm fine to take the change for the model name, so that the workaround
can be added via model option, but rather avoid applying the quirk
from this SSID.

Note that there are already a few similar entries, but those are only
for the early reference boards.


thanks,

Takashi