2023-07-02 19:18:07

by Tom Rix

Subject: [PATCH] thunderbolt: set variable tmu_params storage class specifier to static

smatch reports
drivers/thunderbolt/tmu.c:30:3: warning: symbol
'tmu_params' was not declared. Should it be static?

This variable is only used in its defining file so should be static.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/thunderbolt/tmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thunderbolt/tmu.c b/drivers/thunderbolt/tmu.c
index 1269f417515b..c789024d7ffe 100644
--- a/drivers/thunderbolt/tmu.c
+++ b/drivers/thunderbolt/tmu.c
@@ -19,7 +19,7 @@ static const unsigned int tmu_rates[] = {
[TB_SWITCH_TMU_MODE_MEDRES_ENHANCED_UNI] = 16,
};

-const struct {
+static const struct {
unsigned int freq_meas_window;
unsigned int avg_const;
unsigned int delta_avg_const;
--
2.27.0

2023-07-31 11:57:55

by Mika Westerberg

Subject: Re: [PATCH] thunderbolt: set variable tmu_params storage class specifier to static

On Sun, Jul 02, 2023 at 03:06:08PM -0400, Tom Rix wrote:
> smatch reports
> drivers/thunderbolt/tmu.c:30:3: warning: symbol
> 'tmu_params' was not declared. Should it be static?
>
> This variable is only used in its defining file so should be static.
>
> Signed-off-by: Tom Rix <[email protected]>

Applied, thanks!