2023-07-05 05:15:09

by Minjie Du

Subject: [PATCH v1] drivers: media: remove duplicate assignments

make second_timeout avoid double assignment.

Signed-off-by: Minjie Du <[email protected]>
---
drivers/media/pci/saa7164/saa7164-fw.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/pci/saa7164/saa7164-fw.c b/drivers/media/pci/saa7164/saa7164-fw.c
index 363689484..cc9f384f7 100644
--- a/drivers/media/pci/saa7164/saa7164-fw.c
+++ b/drivers/media/pci/saa7164/saa7164-fw.c
@@ -271,7 +271,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
dprintk(DBGLVL_FW, "%s() Loader 1 has loaded.\n",
__func__);
first_timeout = SAA_DEVICE_TIMEOUT;
- second_timeout = 60 * SAA_DEVICE_TIMEOUT;
second_timeout = 100;

err_flags = saa7164_readl(SAA_SECONDSTAGEERROR_FLAGS);
--
2.39.0

2023-07-05 06:41:22

by Hans Verkuil

Subject: Re: [PATCH v1] drivers: media: remove duplicate assignments

On 05/07/2023 06:47, Minjie Du wrote:
> make second_timeout avoid double assignment.

Please post a v2 where you mention the driver name in the subject.

"drivers: media:" suggests a patch touching on many media drivers instead
of just a single driver.

Regards,

Hans

>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> drivers/media/pci/saa7164/saa7164-fw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/pci/saa7164/saa7164-fw.c b/drivers/media/pci/saa7164/saa7164-fw.c
> index 363689484..cc9f384f7 100644
> --- a/drivers/media/pci/saa7164/saa7164-fw.c
> +++ b/drivers/media/pci/saa7164/saa7164-fw.c
> @@ -271,7 +271,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
> dprintk(DBGLVL_FW, "%s() Loader 1 has loaded.\n",
> __func__);
> first_timeout = SAA_DEVICE_TIMEOUT;
> - second_timeout = 60 * SAA_DEVICE_TIMEOUT;
> second_timeout = 100;
>
> err_flags = saa7164_readl(SAA_SECONDSTAGEERROR_FLAGS);