2023-07-05 11:03:31

by Minjie Du

[permalink] [raw]
Subject: [PATCH v2] qed: Remove a duplicate assignment in qed_rdma_create_srq()

Delete a duplicate statement from this function implementation.

Signed-off-by: Minjie Du <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_rdma.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
index 5a5dbbb8d..41efced49 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -1795,7 +1795,6 @@ qed_rdma_create_srq(void *rdma_cxt,

opaque_fid = p_hwfn->hw_info.opaque_fid;

- opaque_fid = p_hwfn->hw_info.opaque_fid;
init_data.opaque_fid = opaque_fid;
init_data.comp_mode = QED_SPQ_MODE_EBLOCK;

--
2.39.0



2023-07-05 11:21:31

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH v2] qed: Remove a duplicate assignment in qed_rdma_create_srq()

On Wed, Jul 05, 2023 at 06:35:46PM +0800, Minjie Du wrote:
> Delete a duplicate statement from this function implementation.
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> drivers/net/ethernet/qlogic/qed/qed_rdma.c | 1 -
> 1 file changed, 1 deletion(-)

This patch should be resubmitted after merge window ends.

Please specify net-next target in patch subject and add changelog
that describes the differences between versions.

Thanks

>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> index 5a5dbbb8d..41efced49 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> @@ -1795,7 +1795,6 @@ qed_rdma_create_srq(void *rdma_cxt,
>
> opaque_fid = p_hwfn->hw_info.opaque_fid;
>
> - opaque_fid = p_hwfn->hw_info.opaque_fid;
> init_data.opaque_fid = opaque_fid;
> init_data.comp_mode = QED_SPQ_MODE_EBLOCK;
>
> --
> 2.39.0
>
>