2023-07-10 03:25:15

by Li zeming

Subject: [PATCH] kernel: params: Remove unnecessary ‘0’ values from err

err is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <[email protected]>
---
kernel/params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/params.c b/kernel/params.c
index 6a7548979aa9..f8837a5f2c3e 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -331,7 +331,7 @@ EXPORT_SYMBOL(param_ops_bool);

int param_set_bool_enable_only(const char *val, const struct kernel_param *kp)
{
- int err = 0;
+ int err;
bool new_value;
bool orig_value = *(bool *)kp->arg;
struct kernel_param dummy_kp = *kp;
--
2.18.2

2023-07-10 03:40:52

by Randy Dunlap

Subject: Re: [PATCH] kernel: params: Remove unnecessary ‘0’ values from err

On 7/11/23 12:43, Li zeming wrote:
> err is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> kernel/params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/params.c b/kernel/params.c
> index 6a7548979aa9..f8837a5f2c3e 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -331,7 +331,7 @@ EXPORT_SYMBOL(param_ops_bool);
>
> int param_set_bool_enable_only(const char *val, const struct kernel_param *kp)
> {
> - int err = 0;
> + int err;
> bool new_value;
> bool orig_value = *(bool *)kp->arg;
> struct kernel_param dummy_kp = *kp;

--
~Randy

2023-07-10 20:05:05

by Luis Chamberlain

Subject: Re: [PATCH] kernel: params: Remo ve unnecessary ‘0’ values from err

On Sun, Jul 09, 2023 at 08:33:28PM -0700, Randy Dunlap wrote:
>
>
> On 7/11/23 12:43, Li zeming wrote:
> > err is assigned first, so it does not need to initialize the assignment.
> >
> > Signed-off-by: Li zeming <[email protected]>
>
> Reviewed-by: Randy Dunlap <[email protected]>

Thanks, I've taken this through the modules tree and pushed out.

Luis