2023-07-12 11:37:50

by Minjie Du

Subject: [PATCH v1] drivers: host: fix parameter check in nvme_fault_inject_init()

Make IS_ERR() judge the debugfs_create_dir() function return.

Signed-off-by: Minjie Du <[email protected]>
---
drivers/nvme/host/fault_inject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/fault_inject.c b/drivers/nvme/host/fault_inject.c
index 83d2e6860..1ba10a5c6 100644
--- a/drivers/nvme/host/fault_inject.c
+++ b/drivers/nvme/host/fault_inject.c
@@ -27,7 +27,7 @@ void nvme_fault_inject_init(struct nvme_fault_inject *fault_inj,

/* create debugfs directory and attribute */
parent = debugfs_create_dir(dev_name, NULL);
- if (!parent) {
+ if (IS_ERR(parent)) {
pr_warn("%s: failed to create debugfs directory\n", dev_name);
return;
}
--
2.39.0

2023-07-12 13:17:16

by Christoph Hellwig

Subject: Re: [PATCH v1] drivers: host: fix parameter check in nvme_fault_inject_init()

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2023-07-12 17:08:14

by Keith Busch

Subject: Re: [PATCH v1] drivers: host: fix parameter check in nvme_fault_inject_init()

Applied, thanks!