Fixes checkpatch errors:
riscv/kernel/probes:ERROR:space prohibited before that close parenthesis
')'
riscv/kernel/probes:ERROR:space prohibited before that close parenthesis
')'
riscv/kernel/probes:ERROR:space prohibited before that close parenthesis
')'
Signed-off-by: ztt <[email protected]>
---
arch/riscv/kernel/probes/simulate-insn.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/riscv/kernel/probes/simulate-insn.c
b/arch/riscv/kernel/probes/simulate-insn.c
index 7441ac8a6843..60792c79b42e 100644
--- a/arch/riscv/kernel/probes/simulate-insn.c
+++ b/arch/riscv/kernel/probes/simulate-insn.c
@@ -128,10 +128,10 @@ bool __kprobes simulate_auipc(u32 opcode, unsigned
long addr, struct pt_regs *re
(((opcode) >> 12) & 0x7)
#define branch_imm(opcode) \
- (((((opcode) >> 8) & 0xf ) << 1) | \
+ (((((opcode) >> 8) & 0xf) << 1) | \
((((opcode) >> 25) & 0x3f) << 5) | \
- ((((opcode) >> 7) & 0x1 ) << 11) | \
- ((((opcode) >> 31) & 0x1 ) << 12))
+ ((((opcode) >> 7) & 0x1) << 11) | \
+ ((((opcode) >> 31) & 0x1) << 12))
#define branch_offset(opcode) \
sign_extend32((branch_imm(opcode)), 12)
Hey,
On Mon, Jul 17, 2023 at 03:48:37PM +0800, [email protected] wrote:
> Fixes checkpatch errors:
>
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis ')'
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis ')'
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis ')'
>
> Signed-off-by: ztt <[email protected]>
Checkpatch complaints that this does not match the email you sent the
patch from. "ztt" is not a known identity either, so that's insufficient
for DCO purposes.
Thirdly, the patch is corrupted, with tabs replaced by spaces.
I've seen a lot of "checkpatch -f" fix patches from 208suo.com people
across various subsystems over the last few weeks that are all corrupted
and do not apply. Please don't send any more for arch/riscv until you
figure out how to send them without corruption.
Thanks,
Conor.
> ---
> arch/riscv/kernel/probes/simulate-insn.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/kernel/probes/simulate-insn.c
> b/arch/riscv/kernel/probes/simulate-insn.c
> index 7441ac8a6843..60792c79b42e 100644
> --- a/arch/riscv/kernel/probes/simulate-insn.c
> +++ b/arch/riscv/kernel/probes/simulate-insn.c
> @@ -128,10 +128,10 @@ bool __kprobes simulate_auipc(u32 opcode, unsigned
> long addr, struct pt_regs *re
> (((opcode) >> 12) & 0x7)
>
> #define branch_imm(opcode) \
> - (((((opcode) >> 8) & 0xf ) << 1) | \
> + (((((opcode) >> 8) & 0xf) << 1) | \
> ((((opcode) >> 25) & 0x3f) << 5) | \
> - ((((opcode) >> 7) & 0x1 ) << 11) | \
> - ((((opcode) >> 31) & 0x1 ) << 12))
> + ((((opcode) >> 7) & 0x1) << 11) | \
> + ((((opcode) >> 31) & 0x1) << 12))
>
> #define branch_offset(opcode) \
> sign_extend32((branch_imm(opcode)), 12)