No need cast (void*) to (struct ems_pci_card *).
Signed-off-by: Wu Yunchuan <[email protected]>
Acked-by: Marc Kleine-Budde<[email protected]>
---
drivers/net/can/sja1000/ems_pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/sja1000/ems_pci.c b/drivers/net/can/sja1000/ems_pci.c
index c56e27223e5f..ac86640998a8 100644
--- a/drivers/net/can/sja1000/ems_pci.c
+++ b/drivers/net/can/sja1000/ems_pci.c
@@ -148,7 +148,7 @@ static void ems_pci_v1_write_reg(const struct sja1000_priv *priv,
static void ems_pci_v1_post_irq(const struct sja1000_priv *priv)
{
- struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+ struct ems_pci_card *card = priv->priv;
/* reset int flag of pita */
writel(PITA2_ICR_INT0_EN | PITA2_ICR_INT0,
@@ -168,7 +168,7 @@ static void ems_pci_v2_write_reg(const struct sja1000_priv *priv,
static void ems_pci_v2_post_irq(const struct sja1000_priv *priv)
{
- struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+ struct ems_pci_card *card = priv->priv;
writel(PLX_ICSR_ENA_CLR, card->conf_addr + PLX_ICSR);
}
@@ -186,7 +186,7 @@ static void ems_pci_v3_write_reg(const struct sja1000_priv *priv,
static void ems_pci_v3_post_irq(const struct sja1000_priv *priv)
{
- struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+ struct ems_pci_card *card = priv->priv;
writel(ASIX_LINTSR_INT0AC, card->conf_addr + ASIX_LINTSR);
}
--
2.30.2
On 17.07.2023 11:12:21, Wu Yunchuan wrote:
> No need cast (void*) to (struct ems_pci_card *).
>
> Signed-off-by: Wu Yunchuan <[email protected]>
> Acked-by: Marc Kleine-Budde<[email protected]>
Please add a space between my name and my e-mail address, so that it
reads:
Acked-by: Marc Kleine-Budde <[email protected]>
nitpick:
You should add your S-o-b as the last trailer.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
On 2023/7/17 14:52, Marc Kleine-Budde wrote:
> On 17.07.2023 11:12:21, Wu Yunchuan wrote:
>> No need cast (void*) to (struct ems_pci_card *).
>>
>> Signed-off-by: Wu Yunchuan <[email protected]>
>> Acked-by: Marc Kleine-Budde<[email protected]>
> Please add a space between my name and my e-mail address, so that it
> reads:
>
> Acked-by: Marc Kleine-Budde <[email protected]>
Hi,
Sorry for this, I will resend this patch to add a space.
>
> nitpick:
> You should add your S-o-b as the last trailer.
Oh, thanks for this reminder!
Wu Yunchuan
> regards,
> Marc
>
On 17.07.2023 08:52:42, Marc Kleine-Budde wrote:
> On 17.07.2023 11:12:21, Wu Yunchuan wrote:
> > No need cast (void*) to (struct ems_pci_card *).
> >
> > Signed-off-by: Wu Yunchuan <[email protected]>
> > Acked-by: Marc Kleine-Budde<[email protected]>
>
> Please add a space between my name and my e-mail address, so that it
> reads:
>
> Acked-by: Marc Kleine-Budde <[email protected]>
>
> nitpick:
> You should add your S-o-b as the last trailer.
BTW: The threading of this series is still broken. Make sure you send
the whole patch series with one single "git send-email" command. For
regular contribution you might have a look at the "b4" [1] tool.
regards,
Marc
[1] https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
On 2023/7/17 15:07, Marc Kleine-Budde wrote:
> On 17.07.2023 08:52:42, Marc Kleine-Budde wrote:
>> On 17.07.2023 11:12:21, Wu Yunchuan wrote:
>>> No need cast (void*) to (struct ems_pci_card *).
>>>
>>> Signed-off-by: Wu Yunchuan <[email protected]>
>>> Acked-by: Marc Kleine-Budde<[email protected]>
>> Please add a space between my name and my e-mail address, so that it
>> reads:
>>
>> Acked-by: Marc Kleine-Budde <[email protected]>
>>
>> nitpick:
>> You should add your S-o-b as the last trailer.
> BTW: The threading of this series is still broken. Make sure you send
> the whole patch series with one single "git send-email" command. For
> regular contribution you might have a look at the "b4" [1] tool.
Hi,
Thanks for you suggestions, I use 'git send-email' to send patch.
I messing up the patch's order in different patchset. This might be the
reason of the broken threading.
Really sorry for this, I will take careful next time.
Wu Yunchuan
> regards,
> Marc
>
> [1] https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1
>
On 17.07.2023 15:30:33, yunchuan wrote:
>
> On 2023/7/17 15:07, Marc Kleine-Budde wrote:
> > On 17.07.2023 08:52:42, Marc Kleine-Budde wrote:
> > > On 17.07.2023 11:12:21, Wu Yunchuan wrote:
> > > > No need cast (void*) to (struct ems_pci_card *).
> > > >
> > > > Signed-off-by: Wu Yunchuan <[email protected]>
> > > > Acked-by: Marc Kleine-Budde<[email protected]>
> > > Please add a space between my name and my e-mail address, so that it
> > > reads:
> > >
> > > Acked-by: Marc Kleine-Budde <[email protected]>
> > >
> > > nitpick:
> > > You should add your S-o-b as the last trailer.
> > BTW: The threading of this series is still broken. Make sure you send
> > the whole patch series with one single "git send-email" command. For
> > regular contribution you might have a look at the "b4" [1] tool.
>
> Hi,
>
> Thanks for you suggestions, I use 'git send-email' to send patch.
> I messing up the patch's order in different patchset. This might be the
> reason of the broken threading.
> Really sorry for this, I will take careful next time.
You should send _all_ 9 patches in the series with a _single_ "git
send-email" command. There's no risk to mess up the order.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
On 2023/7/17 15:33, Marc Kleine-Budde wrote:
> On 17.07.2023 15:30:33, yunchuan wrote:
>> On 2023/7/17 15:07, Marc Kleine-Budde wrote:
>>> On 17.07.2023 08:52:42, Marc Kleine-Budde wrote:
>>>> On 17.07.2023 11:12:21, Wu Yunchuan wrote:
>>>>> No need cast (void*) to (struct ems_pci_card *).
>>>>>
>>>>> Signed-off-by: Wu Yunchuan <[email protected]>
>>>>> Acked-by: Marc Kleine-Budde<[email protected]>
>>>> Please add a space between my name and my e-mail address, so that it
>>>> reads:
>>>>
>>>> Acked-by: Marc Kleine-Budde <[email protected]>
>>>>
>>>> nitpick:
>>>> You should add your S-o-b as the last trailer.
>>> BTW: The threading of this series is still broken. Make sure you send
>>> the whole patch series with one single "git send-email" command. For
>>> regular contribution you might have a look at the "b4" [1] tool.
>> Hi,
>>
>> Thanks for you suggestions, I use 'git send-email' to send patch.
>> I messing up the patch's order in different patchset. This might be the
>> reason of the broken threading.
>> Really sorry for this, I will take careful next time.
> You should send _all_ 9 patches in the series with a _single_ "git
> send-email" command. There's no risk to mess up the order.
Got it, thanks for your reply!
Wu Yunchuan
>
> regards,
> Marc
>