2023-07-17 09:36:35

by hanyu001

Subject: [PATCH] drivers: extcon: space required after that ','

This patch fixes the checkpatch.pl error:

./drivers/extcon/extcon.c:321: ERROR: space required after that ','
(ctx:VxV)

Signed-off-by: maqimei <[email protected]>
---
drivers/extcon/extcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 6f7a60d..4ef4422 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned
int id, unsigned int prop)
}

static int is_extcon_property_capability(struct extcon_dev *edev,
- unsigned int id, int index,unsigned int prop)
+ unsigned int id, int index, unsigned int prop)
{
struct extcon_cable *cable;
int type, ret;

2023-07-17 10:35:27

by MyungJoo Ham

Subject: RE: [PATCH] drivers: extcon: space required after that ','

>This patch fixes the checkpatch.pl error:
>
>./drivers/extcon/extcon.c:321: ERROR: space required after that ','
>(ctx:VxV)
>
>Signed-off-by: maqimei <[email protected]>

Acked-by: MyungJoo Ham <[email protected]>

@Chanwoo, it looks like that's from a 7 years old commit of yours :).

>---
> drivers/extcon/extcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
>index 6f7a60d..4ef4422 100644
>--- a/drivers/extcon/extcon.c
>+++ b/drivers/extcon/extcon.c
>@@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned
>int id, unsigned int prop)
> }
>
> static int is_extcon_property_capability(struct extcon_dev *edev,
>- unsigned int id, int index,unsigned int prop)
>+ unsigned int id, int index, unsigned int prop)
> {
> struct extcon_cable *cable;
> int type, ret;

2023-07-23 14:06:25

by Chanwoo Choi

Subject: Re: [PATCH] drivers: extcon: space required after that ','

Hi,

On 23. 7. 17. 18:03, [email protected] wrote:
> This patch fixes the checkpatch.pl error:
>
> ./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: maqimei <[email protected]>

'maqimei' is your name?

I recommend that you can check the guide of 'submitting-patches'[1].
[1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

Please update your name.

> ---
>  drivers/extcon/extcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 6f7a60d..4ef4422 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned int id, unsigned int prop)
>  }
>
>  static int is_extcon_property_capability(struct extcon_dev *edev,
> -                unsigned int id, int index,unsigned int prop)
> +                unsigned int id, int index, unsigned int prop)
>  {
>      struct extcon_cable *cable;
>      int type, ret;

--
Best Regards,
Samsung Electronics
Chanwoo Choi