2023-07-18 01:07:09

by Yang Li

Subject: [PATCH -next] media: i2c: No need to set device_driver owner

Remove .owner field if calls are used which set it automatically.

to silence the warning:
./drivers/media/i2c/ds90ub953.c:1390:3-8: No need to set .owner here. The core will do it.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5902
Signed-off-by: Yang Li <[email protected]>
---
drivers/media/i2c/ds90ub953.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
index 1e3827a60029..ce1c6f8b656e 100644
--- a/drivers/media/i2c/ds90ub953.c
+++ b/drivers/media/i2c/ds90ub953.c
@@ -1387,7 +1387,6 @@ static struct i2c_driver ds90ub953_driver = {
.id_table = ub953_id,
.driver = {
.name = "ds90ub953",
- .owner = THIS_MODULE,
.of_match_table = ub953_dt_ids,
},
};
--
2.20.1.7.g153144c

2023-07-18 07:41:13

by Tomi Valkeinen

Subject: Re: [PATCH -next] media: i2c: No need to set device_driver owner

On 18/07/2023 04:01, Yang Li wrote:
> Remove .owner field if calls are used which set it automatically.
>
> to silence the warning:
> ./drivers/media/i2c/ds90ub953.c:1390:3-8: No need to set .owner here. The core will do it.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5902
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/media/i2c/ds90ub953.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 1e3827a60029..ce1c6f8b656e 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -1387,7 +1387,6 @@ static struct i2c_driver ds90ub953_driver = {
> .id_table = ub953_id,
> .driver = {
> .name = "ds90ub953",
> - .owner = THIS_MODULE,
> .of_match_table = ub953_dt_ids,
> },
> };

Reviewed-by: Tomi Valkeinen <[email protected]>

Tomi