2023-07-23 04:05:01

by Miaohe Lin

Subject: [PATCH] mm/mprotect: fix obsolete function name in change_pte_range()

Since commit 79a1971c5f14 ("mm: move the copy_one_pte() pte_present check
into the caller"), the explanation of preserving soft-dirtiness is moved
into copy_nonpresent_pte(). Update corresponding comment.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/mprotect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/mprotect.c b/mm/mprotect.c
index 5c3112d92466..3f36c88a238e 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -213,7 +213,7 @@ static long change_pte_range(struct mmu_gather *tlb,
} else if (is_writable_device_private_entry(entry)) {
/*
* We do not preserve soft-dirtiness. See
- * copy_one_pte() for explanation.
+ * copy_nonpresent_pte() for explanation.
*/
entry = make_readable_device_private_entry(
swp_offset(entry));
--
2.33.0

2023-07-25 16:20:27

by David Hildenbrand

Subject: Re: [PATCH] mm/mprotect: fix obsolete function name in change_pte_range()

On 23.07.23 05:31, Miaohe Lin wrote:
> Since commit 79a1971c5f14 ("mm: move the copy_one_pte() pte_present check
> into the caller"), the explanation of preserving soft-dirtiness is moved
> into copy_nonpresent_pte(). Update corresponding comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> mm/mprotect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 5c3112d92466..3f36c88a238e 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -213,7 +213,7 @@ static long change_pte_range(struct mmu_gather *tlb,
> } else if (is_writable_device_private_entry(entry)) {
> /*
> * We do not preserve soft-dirtiness. See
> - * copy_one_pte() for explanation.
> + * copy_nonpresent_pte() for explanation.
> */
> entry = make_readable_device_private_entry(
> swp_offset(entry));

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb