2023-07-26 09:21:58

by Li Zetao

Subject: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static

This patch fixes the following sprse warning:

arch/x86/boot/compressed/sev.c:28:13: warning:
symbol boot_ghcb_page was not declared. Should it be static?
arch/x86/boot/compressed/sev.c:29:13: warning:
symbol boot_ghcb was not declared. Should it be static?

No functional change intended.

Signed-off-by: Li Zetao <[email protected]>
---
arch/x86/boot/compressed/sev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
index 09dc8c187b3c..323f6298a6b2 100644
--- a/arch/x86/boot/compressed/sev.c
+++ b/arch/x86/boot/compressed/sev.c
@@ -25,8 +25,8 @@
#include "error.h"
#include "../msr.h"

-struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
-struct ghcb *boot_ghcb;
+static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
+static struct ghcb *boot_ghcb;

/*
* Copy a version of this function here - insn-eval.c can't be used in
--
2.34.1

2023-07-26 10:53:12

by Nikunj A. Dadhania

Subject: Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static

On 7/26/2023 10:36 PM, Li Zetao wrote:
> This patch fixes the following sprse warning:

s/sprse/sparse

>
> arch/x86/boot/compressed/sev.c:28:13: warning:
> symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> symbol boot_ghcb was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Li Zetao <[email protected]>

With the above nit fixed

Reviewed-by: Nikunj A Dadhania <[email protected]>

> ---
> arch/x86/boot/compressed/sev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
> #include "error.h"
> #include "../msr.h"
>
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>
> /*
> * Copy a version of this function here - insn-eval.c can't be used in

Regards,
Nikunj

2023-07-26 14:31:08

by Tom Lendacky

Subject: Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static

On 7/26/23 12:06, Li Zetao wrote:
> This patch fixes the following sprse warning:
>
> arch/x86/boot/compressed/sev.c:28:13: warning:
> symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> symbol boot_ghcb was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Li Zetao <[email protected]>

Reviewed-by: Tom Lendacky <[email protected]>

> ---
> arch/x86/boot/compressed/sev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
> #include "error.h"
> #include "../msr.h"
>
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>
> /*
> * Copy a version of this function here - insn-eval.c can't be used in