2023-07-28 11:47:27

by Sven Schnelle

Subject: [PATCH] s390/certstore: select CRYPTO_LIB_SHA256

A build failure was reported when sha256() is not present:

gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'

Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.

Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
Reported-by: Randy Dunlap <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Sven Schnelle <[email protected]>
---
arch/s390/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index d9d50a7a2016..18bf754e1fad 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -516,6 +516,7 @@ config KEXEC_SIG
config CERT_STORE
bool "Get user certificates via DIAG320"
depends on KEYS
+ select CRYPTO_LIB_SHA256
help
Enable this option if you want to access user-provided secure boot
certificates via DIAG 0x320.
--
2.39.2

2023-07-29 14:29:28

by Heiko Carstens

Subject: Re: [PATCH] s390/certstore: select CRYPTO_LIB_SHA256

On Fri, Jul 28, 2023 at 12:04:30PM +0200, Sven Schnelle wrote:
> A build failure was reported when sha256() is not present:
>
> gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
> arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'
>
> Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.
>
> Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
> Reported-by: Randy Dunlap <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Sven Schnelle <[email protected]>
> ---
> arch/s390/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks!

2023-08-01 03:09:32

by Randy Dunlap

Subject: Re: [PATCH] s390/certstore: select CRYPTO_LIB_SHA256

On 7/28/23 03:04, Sven Schnelle wrote:
> A build failure was reported when sha256() is not present:
>
> gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
> arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'
>
> Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.
>
> Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
> Reported-by: Randy Dunlap <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Sven Schnelle <[email protected]>

Sorry for the delay.

Tested-by: Randy Dunlap <[email protected]> # build-tested
Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> arch/s390/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index d9d50a7a2016..18bf754e1fad 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -516,6 +516,7 @@ config KEXEC_SIG
> config CERT_STORE
> bool "Get user certificates via DIAG320"
> depends on KEYS
> + select CRYPTO_LIB_SHA256
> help
> Enable this option if you want to access user-provided secure boot
> certificates via DIAG 0x320.

--
~Randy