2023-08-01 01:09:19

by Yang Li

[permalink] [raw]
Subject: [PATCH net-next] net: Remove duplicated include in mac.c

./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/ethernet/freescale/fman/mac.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index b6c7c4c0b367..9767586b4eb3 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -12,7 +12,6 @@
#include <linux/of_net.h>
#include <linux/of_mdio.h>
#include <linux/device.h>
-#include <linux/of_platform.h>
#include <linux/phy.h>
#include <linux/netdevice.h>
#include <linux/phy_fixed.h>
--
2.20.1.7.g153144c



2023-08-01 10:19:23

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net-next] net: Remove duplicated include in mac.c

On Tue, Aug 01, 2023 at 08:50:41AM +0800, Yang Li wrote:
> ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
> Signed-off-by: Yang Li <[email protected]>

Looking at git history, I think that a slightly better prefix would be
'net: fman: '.

Subject: [PATCH net-next] net: fman: ...

But other than that, this looks good to me.

Reviewed-by: Simon Horman <[email protected]>

2023-08-02 11:26:52

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next] net: Remove duplicated include in mac.c

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Tue, 1 Aug 2023 08:50:41 +0800 you wrote:
> ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/net/ethernet/freescale/fman/mac.c | 1 -
> 1 file changed, 1 deletion(-)

Here is the summary with links:
- [net-next] net: Remove duplicated include in mac.c
https://git.kernel.org/netdev/net-next/c/34093c9fa05d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html