2023-07-31 02:39:40

by Li zeming

Subject: [PATCH] user_namespace: Remove unnecessary ‘NULL’ values from map_write

kbuf is assigned first, so it does not need to initialize the
assignment.

Signed-off-by: Li zeming <[email protected]>
---
kernel/user_namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
index 1d8e47bed3f1..6fabf388bb8a 100644
--- a/kernel/user_namespace.c
+++ b/kernel/user_namespace.c
@@ -928,7 +928,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
struct uid_gid_map new_map;
unsigned idx;
struct uid_gid_extent extent;
- char *kbuf = NULL, *pos, *next_line;
+ char *kbuf, *pos, *next_line;
ssize_t ret;

/* Only allow < page size writes at the beginning of the file */
--
2.18.2

2023-08-01 02:41:29

by Randy Dunlap

Subject: Re: [PATCH] user_namespace: Remove unnecessary ‘NULL’ values from map_write

On 8/1/23 11:45, Li zeming wrote:

^^^^^^^^^^^^^^^

Please fix your system's date/time.

> kbuf is assigned first, so it does not need to initialize the
> assignment.
>
> Signed-off-by: Li zeming <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> kernel/user_namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
> index 1d8e47bed3f1..6fabf388bb8a 100644
> --- a/kernel/user_namespace.c
> +++ b/kernel/user_namespace.c
> @@ -928,7 +928,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
> struct uid_gid_map new_map;
> unsigned idx;
> struct uid_gid_extent extent;
> - char *kbuf = NULL, *pos, *next_line;
> + char *kbuf, *pos, *next_line;
> ssize_t ret;
>
> /* Only allow < page size writes at the beginning of the file */

--
~Randy