2023-08-01 16:13:23

by Thomas Weißschuh

Subject: Re: [PATCH v3 0/2] tools/nolibc: add pipe(), pipe2() and their testcase

Aug 1, 2023 17:40:01 Yuan Tan <[email protected]>:

> Hi Willy and Thomas,
>
> In v3, I have fixed all the problems you mentioned.
>
> Welcome any other suggestion.
>
> ---
> Changes in v3:
> - Fix the missing return
> - Fix __NR_pipe to __NR_pipe2
> - Fix the missing static
> - Test case works in one process
> - Link to v2:
>   https://lore.kernel.org/all/[email protected]
>
> Changes in v2:
> - Use sys_pipe2 to implement the pipe()
> - Use memcmp() instead of strcmp()
> - Link to v1:
>   https://lore.kernel.org/all/[email protected]
>
> ---
> Yuan Tan (2):
>   tools/nolibc: add pipe() and pipe2() support
>   selftests/nolibc: add testcase for pipe
>
> tools/include/nolibc/sys.h                   | 24 ++++++++++++++++++++
> tools/testing/selftests/nolibc/nolibc-test.c | 22 ++++++++++++++++++
> 2 files changed, 46 insertions(+)

For the full series:

Reviewed-by: Thomas Weißschuh <[email protected]>

Thanks!

2023-08-01 20:41:04

by Willy Tarreau

Subject: Re: [PATCH v3 0/2] tools/nolibc: add pipe(), pipe2() and their testcase

Hi,

On Tue, Aug 01, 2023 at 05:42:57PM +0200, Thomas Wei?schuh wrote:
>
> Aug 1, 2023 17:40:01 Yuan Tan <[email protected]>:
>
> > Hi Willy and Thomas,
> >
> > In v3, I have fixed all the problems you mentioned.
> >
> > Welcome any other suggestion.
> >
> > ---
> > Changes in v3:
> > - Fix the missing return
> > - Fix __NR_pipe to __NR_pipe2
> > - Fix the missing static
> > - Test case works in one process
> > - Link to v2:
> > ? https://lore.kernel.org/all/[email protected]
> >
> > Changes in v2:
> > - Use sys_pipe2 to implement the pipe()
> > - Use memcmp() instead of strcmp()
> > - Link to v1:
> > ? https://lore.kernel.org/all/[email protected]
> >
> > ---
> > Yuan Tan (2):
> > ? tools/nolibc: add pipe() and pipe2() support
> > ? selftests/nolibc: add testcase for pipe
> >
> > tools/include/nolibc/sys.h?????????????????? | 24 ++++++++++++++++++++
> > tools/testing/selftests/nolibc/nolibc-test.c | 22 ++++++++++++++++++
> > 2 files changed, 46 insertions(+)
>
> For the full series:
>
> Reviewed-by: Thomas Wei?schuh <[email protected]>

Thank you both, now queued on top of the rest in 20230801-nolibc-next-1.
Thomas I'll try to review your last series tomorrow, at first glance it
looks OK.

Thanks,
Willy