2023-08-03 16:00:41

by Artem Chernyshev

Subject: [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry()

Process result of ocfs2_add_entry() in case we have an error
value.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem")
Signed-off-by: Artem Chernyshev <[email protected]>
---
fs/ocfs2/namei.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 17c52225b87d..03bccfd183f3 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap,
status = ocfs2_add_entry(handle, new_dentry, old_inode,
OCFS2_I(old_inode)->ip_blkno,
new_dir_bh, &target_insert);
+ if (status < 0) {
+ mlog_errno(status);
+ goto bail;
+ }
}

old_inode->i_ctime = current_time(old_inode);
--
2.37.3

2023-08-04 02:00:21

by Joseph Qi

Subject: Re: [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry()

On 8/3/23 10:54 PM, Artem Chernyshev wrote:
> Process result of ocfs2_add_entry() in case we have an error
> value.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem")
> Signed-off-by: Artem Chernyshev <[email protected]>

Reviewed-by: Joseph Qi <[email protected]>

> ---
> fs/ocfs2/namei.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 17c52225b87d..03bccfd183f3 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap,
> status = ocfs2_add_entry(handle, new_dentry, old_inode,
> OCFS2_I(old_inode)->ip_blkno,
> new_dir_bh, &target_insert);
> + if (status < 0) {
> + mlog_errno(status);
> + goto bail;
> + }
> }
>
> old_inode->i_ctime = current_time(old_inode);