2023-08-08 16:20:36

by Xi Ruoyao

Subject: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"

In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so
there is no need to source it in the port-specific Kconfig file. And
sourcing it here also caused the "Firmware Drivers" menu appeared two
times: once in the "Device Drivers" menu, another time in the toplevel
menu. This was really puzzling.

Signed-off-by: Xi Ruoyao <[email protected]>
---
arch/loongarch/Kconfig | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
index e71d5bf2cee0..465759f6b0ed 100644
--- a/arch/loongarch/Kconfig
+++ b/arch/loongarch/Kconfig
@@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
source "drivers/acpi/Kconfig"

endmenu
-
-source "drivers/firmware/Kconfig"
--
2.41.0

2023-08-08 17:47:36

by Xi Ruoyao

Subject: Re: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"

On Tue, 2023-08-08 at 15:16 +0800, Huacai Chen wrote:
> Hi, Ruoyao,
>
> I think the title should be "LoongArch: Remove redundant "source
> drivers/firmware/Kconfig""?

Yes, it looks better. I've sent v2 with the change.

Thanks!

>
> Huacai
>
> On Tue, Aug 8, 2023 at 11:49 AM Xi Ruoyao <[email protected]> wrote:
> >
> > In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all
> > ports so
> > there is no need to source it in the port-specific Kconfig file. 
> > And
> > sourcing it here also caused the "Firmware Drivers" menu appeared
> > two
> > times: once in the "Device Drivers" menu, another time in the
> > toplevel
> > menu.  This was really puzzling.
> >
> > Signed-off-by: Xi Ruoyao <[email protected]>
> > ---
> >  arch/loongarch/Kconfig | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> > index e71d5bf2cee0..465759f6b0ed 100644
> > --- a/arch/loongarch/Kconfig
> > +++ b/arch/loongarch/Kconfig
> > @@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
> >  source "drivers/acpi/Kconfig"
> >
> >  endmenu
> > -
> > -source "drivers/firmware/Kconfig"
> > --
> > 2.41.0
> >

--
Xi Ruoyao <[email protected]>
School of Aerospace Science and Technology, Xidian University

2023-08-08 20:13:21

by Huacai Chen

Subject: Re: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"

Hi, Ruoyao,

I think the title should be "LoongArch: Remove redundant "source
drivers/firmware/Kconfig""?

Huacai

On Tue, Aug 8, 2023 at 11:49 AM Xi Ruoyao <[email protected]> wrote:
>
> In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so
> there is no need to source it in the port-specific Kconfig file. And
> sourcing it here also caused the "Firmware Drivers" menu appeared two
> times: once in the "Device Drivers" menu, another time in the toplevel
> menu. This was really puzzling.
>
> Signed-off-by: Xi Ruoyao <[email protected]>
> ---
> arch/loongarch/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index e71d5bf2cee0..465759f6b0ed 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
> source "drivers/acpi/Kconfig"
>
> endmenu
> -
> -source "drivers/firmware/Kconfig"
> --
> 2.41.0
>