2023-08-09 15:47:15

by Petr Oros

[permalink] [raw]
Subject: [PATCH net v2 0/2] Fix VF to VM attach detach

v2: fixed typos in the description of the second patch

v1: https://lore.kernel.org/netdev/[email protected]/

Petr Oros (2):
Revert "ice: Fix ice VF reset during iavf initialization"
ice: Fix NULL pointer deref during VF reset

drivers/net/ethernet/intel/ice/ice_sriov.c | 8 ++---
drivers/net/ethernet/intel/ice/ice_vf_lib.c | 34 +++++--------------
drivers/net/ethernet/intel/ice/ice_vf_lib.h | 1 -
drivers/net/ethernet/intel/ice/ice_virtchnl.c | 1 -
4 files changed, 12 insertions(+), 32 deletions(-)

--
2.41.0



2023-08-10 14:24:52

by Przemek Kitszel

[permalink] [raw]
Subject: Re: [PATCH net v2 0/2] Fix VF to VM attach detach

On 8/9/23 17:15, Petr Oros wrote:
> v2: fixed typos in the description of the second patch
>
> v1: https://lore.kernel.org/netdev/[email protected]/
>
> Petr Oros (2):
> Revert "ice: Fix ice VF reset during iavf initialization"
> ice: Fix NULL pointer deref during VF reset
>
> drivers/net/ethernet/intel/ice/ice_sriov.c | 8 ++---
> drivers/net/ethernet/intel/ice/ice_vf_lib.c | 34 +++++--------------
> drivers/net/ethernet/intel/ice/ice_vf_lib.h | 1 -
> drivers/net/ethernet/intel/ice/ice_virtchnl.c | 1 -
> 4 files changed, 12 insertions(+), 32 deletions(-)
>

You have forgot to propagate reviewed-by tags from v1 (Simon's, Jake's,
mine)

Reviewed-by: Przemek Kitszel <[email protected]>

(I'm not sure if I should copy-paste not mine RBs here?)

2023-08-10 16:36:30

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net v2 0/2] Fix VF to VM attach detach

On Thu, 10 Aug 2023 14:52:33 +0200 Przemek Kitszel wrote:
> You have forgot to propagate reviewed-by tags from v1 (Simon's, Jake's,
> mine)
>
> Reviewed-by: Przemek Kitszel <[email protected]>
>
> (I'm not sure if I should copy-paste not mine RBs here?)

Not 100% sure either but most of the time I reckon it'd be a good thing.
Higher probability that we may miss a tag than that the person intended
to withdraw it. Just make sure the person who's tag you're copying is
on CC and that you add a link to where the tag was provided.