2023-08-11 17:00:44

by Min-Hua Chen

[permalink] [raw]
Subject: [PATCH 2/2] docs: sparse: convert TW sparse.txt into sparse.rst

Follow Randy's advice [1] to move
Documentation/translations/zh_TW/dev-tools/sparse.txt
to
Documentation/translations/zh_TW/dev-tools/sparse.rst

[1] https://lore.kernel.org/lkml/[email protected]/

Cc: Randy Dunlap <[email protected]>
Signed-off-by: Min-Hua Chen <[email protected]>
---
.../dev-tools/{sparse.txt => sparse.rst} | 31 ++++++-------------
1 file changed, 10 insertions(+), 21 deletions(-)
rename Documentation/translations/zh_TW/dev-tools/{sparse.txt => sparse.rst} (71%)

diff --git a/Documentation/translations/zh_TW/dev-tools/sparse.txt b/Documentation/translations/zh_TW/dev-tools/sparse.rst
similarity index 71%
rename from Documentation/translations/zh_TW/dev-tools/sparse.txt
rename to Documentation/translations/zh_TW/dev-tools/sparse.rst
index 6d2d088b1060..2f632f6ce8e8 100644
--- a/Documentation/translations/zh_TW/dev-tools/sparse.txt
+++ b/Documentation/translations/zh_TW/dev-tools/sparse.rst
@@ -1,33 +1,22 @@
-Chinese translated version of Documentation/dev-tools/sparse.rst
-
-If you have any comment or update to the content, please contact the
-original document maintainer directly. However, if you have a problem
-communicating in English you can also ask the Chinese maintainer for
-help. Contact the Chinese maintainer if this translation is outdated
-or if there is a problem with the translation.
+Copyright 2004 Linus Torvalds
+Copyright 2004 Pavel Machek <[email protected]>
+Copyright 2006 Bob Copeland <[email protected]>

-Traditional Chinese maintainer: Hu Haowen <[email protected]>
----------------------------------------------------------------------
-Documentation/dev-tools/sparse.rst 的繁體中文翻譯
+.. include:: ../disclaimer-zh_TW.rst

-如果想評論或更新本文的內容,請直接聯繫原文檔的維護者。如果你使用英文
-交流有困難的話,也可以向繁體中文版維護者求助。如果本翻譯更新不及時或
-者翻譯存在問題,請聯繫繁體中文版維護者。
+:Original: Documentation/dev-tools/sparse.rst

-繁體中文版維護者: 胡皓文 Hu Haowen <[email protected]>
-繁體中文版翻譯者: 胡皓文 Hu Haowen <[email protected]>
+:翻譯:

-以下爲正文
----------------------------------------------------------------------
+Traditional Chinese maintainer: Hu Haowen <[email protected]>

-Copyright 2004 Linus Torvalds
-Copyright 2004 Pavel Machek <[email protected]>
-Copyright 2006 Bob Copeland <[email protected]>
+Sparse
+======

使用 sparse 工具做類型檢查
~~~~~~~~~~~~~~~~~~~~~~~~~~

-"__bitwise" 是一種類型屬性,所以你應該這樣使用它:
+"__bitwise" 是一種類型屬性,所以你應該這樣使用它::

typedef int __bitwise pm_request_t;

--
2.34.1



2023-08-11 19:03:44

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH 2/2] docs: sparse: convert TW sparse.txt into sparse.rst



On 8/11/23 08:35, Min-Hua Chen wrote:
> Follow Randy's advice [1] to move
> Documentation/translations/zh_TW/dev-tools/sparse.txt
> to
> Documentation/translations/zh_TW/dev-tools/sparse.rst
>
> [1] https://lore.kernel.org/lkml/[email protected]/
>
> Cc: Randy Dunlap <[email protected]>
> Signed-off-by: Min-Hua Chen <[email protected]>

Acked-by: Randy Dunlap <[email protected]>
Thanks.

> ---
> .../dev-tools/{sparse.txt => sparse.rst} | 31 ++++++-------------
> 1 file changed, 10 insertions(+), 21 deletions(-)
> rename Documentation/translations/zh_TW/dev-tools/{sparse.txt => sparse.rst} (71%)
>
> diff --git a/Documentation/translations/zh_TW/dev-tools/sparse.txt b/Documentation/translations/zh_TW/dev-tools/sparse.rst
> similarity index 71%
> rename from Documentation/translations/zh_TW/dev-tools/sparse.txt
> rename to Documentation/translations/zh_TW/dev-tools/sparse.rst
> index 6d2d088b1060..2f632f6ce8e8 100644
> --- a/Documentation/translations/zh_TW/dev-tools/sparse.txt
> +++ b/Documentation/translations/zh_TW/dev-tools/sparse.rst
> @@ -1,33 +1,22 @@
> -Chinese translated version of Documentation/dev-tools/sparse.rst
> -
> -If you have any comment or update to the content, please contact the
> -original document maintainer directly. However, if you have a problem
> -communicating in English you can also ask the Chinese maintainer for
> -help. Contact the Chinese maintainer if this translation is outdated
> -or if there is a problem with the translation.
> +Copyright 2004 Linus Torvalds
> +Copyright 2004 Pavel Machek <[email protected]>
> +Copyright 2006 Bob Copeland <[email protected]>
>
> -Traditional Chinese maintainer: Hu Haowen <[email protected]>
> ----------------------------------------------------------------------
> -Documentation/dev-tools/sparse.rst 的繁體中文翻譯
> +.. include:: ../disclaimer-zh_TW.rst
>
> -如果想評論或更新本文的內容,請直接聯繫原文檔的維護者。如果你使用英文
> -交流有困難的話,也可以向繁體中文版維護者求助。如果本翻譯更新不及時或
> -者翻譯存在問題,請聯繫繁體中文版維護者。
> +:Original: Documentation/dev-tools/sparse.rst
>
> -繁體中文版維護者: 胡皓文 Hu Haowen <[email protected]>
> -繁體中文版翻譯者: 胡皓文 Hu Haowen <[email protected]>
> +:翻譯:
>
> -以下爲正文
> ----------------------------------------------------------------------
> +Traditional Chinese maintainer: Hu Haowen <[email protected]>
>
> -Copyright 2004 Linus Torvalds
> -Copyright 2004 Pavel Machek <[email protected]>
> -Copyright 2006 Bob Copeland <[email protected]>
> +Sparse
> +======
>
> 使用 sparse 工具做類型檢查
> ~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> -"__bitwise" 是一種類型屬性,所以你應該這樣使用它:
> +"__bitwise" 是一種類型屬性,所以你應該這樣使用它::
>
> typedef int __bitwise pm_request_t;
>

--
~Randy

2023-08-11 21:37:10

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH 2/2] docs: sparse: convert TW sparse.txt into sparse.rst

Min-Hua Chen <[email protected]> writes:

> Follow Randy's advice [1] to move
> Documentation/translations/zh_TW/dev-tools/sparse.txt
> to
> Documentation/translations/zh_TW/dev-tools/sparse.rst
>
> [1] https://lore.kernel.org/lkml/[email protected]/

So the right way to do this would be to simply say something like
"Convert sparse.txt to RST", then add a Suggested-by: tag to credit
Randy.

> Cc: Randy Dunlap <[email protected]>
> Signed-off-by: Min-Hua Chen <[email protected]>
> ---
> .../dev-tools/{sparse.txt => sparse.rst} | 31 ++++++-------------
> 1 file changed, 10 insertions(+), 21 deletions(-)
> rename Documentation/translations/zh_TW/dev-tools/{sparse.txt => sparse.rst} (71%)

You're not adding this new document to a toctree anywhere; that will add
a warning and this file won't be a part of the docs build.

> diff --git a/Documentation/translations/zh_TW/dev-tools/sparse.txt b/Documentation/translations/zh_TW/dev-tools/sparse.rst
> similarity index 71%
> rename from Documentation/translations/zh_TW/dev-tools/sparse.txt
> rename to Documentation/translations/zh_TW/dev-tools/sparse.rst
> index 6d2d088b1060..2f632f6ce8e8 100644
> --- a/Documentation/translations/zh_TW/dev-tools/sparse.txt
> +++ b/Documentation/translations/zh_TW/dev-tools/sparse.rst
> @@ -1,33 +1,22 @@
> -Chinese translated version of Documentation/dev-tools/sparse.rst
> -
> -If you have any comment or update to the content, please contact the
> -original document maintainer directly. However, if you have a problem
> -communicating in English you can also ask the Chinese maintainer for
> -help. Contact the Chinese maintainer if this translation is outdated
> -or if there is a problem with the translation.
> +Copyright 2004 Linus Torvalds
> +Copyright 2004 Pavel Machek <[email protected]>
> +Copyright 2006 Bob Copeland <[email protected]>
>
> -Traditional Chinese maintainer: Hu Haowen <[email protected]>
> ----------------------------------------------------------------------
> -Documentation/dev-tools/sparse.rst 的繁體中文翻譯
> +.. include:: ../disclaimer-zh_TW.rst
>
> -如果想評論或更新本文的內容,請直接聯繫原文檔的維護者。如果你使用英文
> -交流有困難的話,也可以向繁體中文版維護者求助。如果本翻譯更新不及時或
> -者翻譯存在問題,請聯繫繁體中文版維護者。
> +:Original: Documentation/dev-tools/sparse.rst
>
> -繁體中文版維護者: 胡皓文 Hu Haowen <[email protected]>
> -繁體中文版翻譯者: 胡皓文 Hu Haowen <[email protected]>
> +:翻譯:

So you are removing a fair amount of text here, much of which I cannot
read. Why are you doing that? In any case, that would appear to be a
change that is independent of the format conversion, and should thus be
in its own patch.

Thanks,

jon

2023-08-12 01:08:34

by Min-Hua Chen

[permalink] [raw]
Subject: Re: [PATCH 2/2] docs: sparse: convert TW sparse.txt into sparse.rst

Hi Jonathan,

>> Follow Randy's advice [1] to move
>> Documentation/translations/zh_TW/dev-tools/sparse.txt
>> to
>> Documentation/translations/zh_TW/dev-tools/sparse.rst
>>
>> [1] https://lore.kernel.org/lkml/bfab7c5b-e4d3-d8d9-afab-f43c0cdf26cf@inf=
>radead.org/
>
>So the right way to do this would be to simply say something like
>"Convert sparse.txt to RST", then add a Suggested-by: tag to credit
>Randy.=20

Got it, I will submit v2 with this subject and add Suggested-by: tag
to credit Randy.

>
>> Cc: Randy Dunlap <[email protected]>
>> Signed-off-by: Min-Hua Chen <[email protected]>
>> ---
>> .../dev-tools/{sparse.txt =3D> sparse.rst} | 31 ++++++-------------
>> 1 file changed, 10 insertions(+), 21 deletions(-)
>> rename Documentation/translations/zh_TW/dev-tools/{sparse.txt =3D> spars=
>e.rst} (71%)
>
>You're not adding this new document to a toctree anywhere; that will add
>a warning and this file won't be a part of the docs build.

I will fix this in v2.

>> diff --git a/Documentation/translations/zh_TW/dev-tools/sparse.txt b/Docu=
>mentation/translations/zh_TW/dev-tools/sparse.rst
>> similarity index 71%
>> rename from Documentation/translations/zh_TW/dev-tools/sparse.txt
>> rename to Documentation/translations/zh_TW/dev-tools/sparse.rst
>> index 6d2d088b1060..2f632f6ce8e8 100644
>> --- a/Documentation/translations/zh_TW/dev-tools/sparse.txt
>> +++ b/Documentation/translations/zh_TW/dev-tools/sparse.rst
>> @@ -1,33 +1,22 @@
>> -=EF=BB=BFChinese translated version of Documentation/dev-tools/sparse.rst
>> -
>> -If you have any comment or update to the content, please contact the
>> -original document maintainer directly. However, if you have a problem
>> -communicating in English you can also ask the Chinese maintainer for
>> -help. Contact the Chinese maintainer if this translation is outdated
>> -or if there is a problem with the translation.
>> +=EF=BB=BFCopyright 2004 Linus Torvalds
>> +Copyright 2004 Pavel Machek <[email protected]>
>> +Copyright 2006 Bob Copeland <[email protected]>
>>=20=20
>> -Traditional Chinese maintainer: Hu Haowen <[email protected]>
>
>So you are removing a fair amount of text here, much of which I cannot
>read. Why are you doing that? In any case, that would appear to be a
>change that is independent of the format conversion, and should thus be
>in its own patch.

The text I removed is replaced by '.. include:: ../disclaimer-zh_TW.rst'.
I will keep the original text and change it in another change.

thanks,
Min-Hua

>
>Thanks,
>
>jon
>