2023-08-11 13:56:52

by Konrad Dybcio

Subject: [PATCH 01/11] interconnect: qcom: qdu1000: Set ACV enable_mask

ACV expects an enable_mask corresponding to the APPS RSC, fill it in.

Fixes: 1f51339f7dd0 ("interconnect: qcom: Add QDU1000/QRU1000 interconnect driver")
Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/interconnect/qcom/bcm-voter.h | 2 ++
drivers/interconnect/qcom/qdu1000.c | 1 +
2 files changed, 3 insertions(+)

diff --git a/drivers/interconnect/qcom/bcm-voter.h b/drivers/interconnect/qcom/bcm-voter.h
index b4d36e349f3c..da92267877f9 100644
--- a/drivers/interconnect/qcom/bcm-voter.h
+++ b/drivers/interconnect/qcom/bcm-voter.h
@@ -16,4 +16,6 @@ struct bcm_voter *of_bcm_voter_get(struct device *dev, const char *name);
void qcom_icc_bcm_voter_add(struct bcm_voter *voter, struct qcom_icc_bcm *bcm);
int qcom_icc_bcm_voter_commit(struct bcm_voter *voter);

+#define ACV_RSC_APPS BIT(3)
+
#endif
diff --git a/drivers/interconnect/qcom/qdu1000.c b/drivers/interconnect/qcom/qdu1000.c
index bf800dd7d4ba..c504bf348294 100644
--- a/drivers/interconnect/qcom/qdu1000.c
+++ b/drivers/interconnect/qcom/qdu1000.c
@@ -769,6 +769,7 @@ static struct qcom_icc_node xs_sys_tcu_cfg = {

static struct qcom_icc_bcm bcm_acv = {
.name = "ACV",
+ .enable_mask = ACV_RSC_APPS,
.num_nodes = 1,
.nodes = { &ebi },
};

--
2.41.0

2023-08-11 20:35:22

by Mike Tipton

Subject: Re: [PATCH 01/11] interconnect: qcom: qdu1000: Set ACV enable_mask

On Fri, Aug 11, 2023 at 03:04:08PM +0200, Konrad Dybcio wrote:
> ACV expects an enable_mask corresponding to the APPS RSC, fill it in.
>
> Fixes: 1f51339f7dd0 ("interconnect: qcom: Add QDU1000/QRU1000 interconnect driver")
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> drivers/interconnect/qcom/bcm-voter.h | 2 ++
> drivers/interconnect/qcom/qdu1000.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/interconnect/qcom/bcm-voter.h b/drivers/interconnect/qcom/bcm-voter.h
> index b4d36e349f3c..da92267877f9 100644
> --- a/drivers/interconnect/qcom/bcm-voter.h
> +++ b/drivers/interconnect/qcom/bcm-voter.h
> @@ -16,4 +16,6 @@ struct bcm_voter *of_bcm_voter_get(struct device *dev, const char *name);
> void qcom_icc_bcm_voter_add(struct bcm_voter *voter, struct qcom_icc_bcm *bcm);
> int qcom_icc_bcm_voter_commit(struct bcm_voter *voter);
>
> +#define ACV_RSC_APPS BIT(3)

This isn't entirely common to all chips. It's been BIT(3) for most of
history and is for all the chips in the series. But there upcoming chips
where it'll be different. There are only a finite number of ACV bits
available, so depending on the requirements they can be repurposed. We
should probably just have the raw mask defined in the target files.

> + #endif diff --git a/drivers/interconnect/qcom/qdu1000.c
> b/drivers/interconnect/qcom/qdu1000.c index bf800dd7d4ba..c504bf348294
> 100644 --- a/drivers/interconnect/qcom/qdu1000.c
> +++ b/drivers/interconnect/qcom/qdu1000.c
> @@ -769,6 +769,7 @@ static struct qcom_icc_node xs_sys_tcu_cfg = {
>
> static struct qcom_icc_bcm bcm_acv = {
> .name = "ACV",
> + .enable_mask = ACV_RSC_APPS,
> .num_nodes = 1,
> .nodes = { &ebi },
> };
>
> --
> 2.41.0
>