2023-08-22 18:55:14

by Nathan Chancellor

Subject: [PATCH] x86/hyperv: Add missing 'inline' to hv_snp_boot_ap() stub

When building without CONFIG_AMD_MEM_ENCRYPT, there are several
repeated instances of -Wunused-function due to missing 'inline' on
the stub of hy_snp_boot_ap():

In file included from drivers/hv/hv_common.c:29:
./arch/x86/include/asm/mshyperv.h:272:12: error: 'hv_snp_boot_ap' defined but not used [-Werror=unused-function]
272 | static int hv_snp_boot_ap(int cpu, unsigned long start_ip) { return 0; }
| ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Add 'inline' to fix the warnings.

Fixes: 44676bb9d566 ("x86/hyperv: Add smp support for SEV-SNP guest")
Signed-off-by: Nathan Chancellor <[email protected]>
---
arch/x86/include/asm/mshyperv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index 6bd9ae04d9c3..b6be267ff3d0 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arch/x86/include/asm/mshyperv.h
@@ -269,7 +269,7 @@ static inline void hv_ghcb_msr_read(u64 msr, u64 *value) {}
static inline bool hv_ghcb_negotiate_protocol(void) { return false; }
static inline void hv_ghcb_terminate(unsigned int set, unsigned int reason) {}
static inline void hv_vtom_init(void) {}
-static int hv_snp_boot_ap(int cpu, unsigned long start_ip) { return 0; }
+static inline int hv_snp_boot_ap(int cpu, unsigned long start_ip) { return 0; }
#endif

extern bool hv_isolation_type_snp(void);

---
base-commit: bb9b0e46b84c19d3dd7d453a2da71a0fdc172b31
change-id: 20230822-hv_snp_boot_ap-missing-inline-205e615e4fe6

Best regards,
--
Nathan Chancellor <[email protected]>

2023-08-23 10:12:51

by Wei Liu

Subject: Re: [PATCH] x86/hyperv: Add missing 'inline' to hv_snp_boot_ap() stub

On Wed, Aug 23, 2023 at 01:00:55AM +0000, Dexuan Cui wrote:
> > From: Nathan Chancellor <[email protected]>
> > Sent: Tuesday, August 22, 2023 11:26 AM
> > [...]
> > When building without CONFIG_AMD_MEM_ENCRYPT, there are several
> > repeated instances of -Wunused-function due to missing 'inline' on
> > the stub of hy_snp_boot_ap():
> >
> > In file included from drivers/hv/hv_common.c:29:
> > ./arch/x86/include/asm/mshyperv.h:272:12: error: 'hv_snp_boot_ap'
> > defined but not used [-Werror=unused-function]
> > 272 | static int hv_snp_boot_ap(int cpu, unsigned long start_ip) { return
> > 0; }
> > | ^~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> >
> > Add 'inline' to fix the warnings.
> >
> > Fixes: 44676bb9d566 ("x86/hyperv: Add smp support for SEV-SNP guest")
> > Signed-off-by: Nathan Chancellor <[email protected]>
>
> Reviewed-by: Dexuan Cui <[email protected]>

Applied. Thanks.