2023-08-30 21:50:05

by Martin Botka

Subject: [PATCH] firmware: smccc: Export both soc_id functions

arm_smccc_get_soc_id_version and arm_smccc_get_soc_id_revision
need to be exported so they can be used by modules.
Currently sun50i cpu freq driver is planning to use these functions.

Signed-off-by: Martin Botka <[email protected]>
---
drivers/firmware/smccc/smccc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/firmware/smccc/smccc.c b/drivers/firmware/smccc/smccc.c
index db818f9dcb8e..b4224da46988 100644
--- a/drivers/firmware/smccc/smccc.c
+++ b/drivers/firmware/smccc/smccc.c
@@ -64,11 +64,13 @@ s32 arm_smccc_get_soc_id_version(void)
{
return smccc_soc_id_version;
}
+EXPORT_SYMBOL_GPL(arm_smccc_get_soc_id_version);

s32 arm_smccc_get_soc_id_revision(void)
{
return smccc_soc_id_revision;
}
+EXPORT_SYMBOL_GPL(arm_smccc_get_soc_id_revision);

static int __init smccc_devices_init(void)
{

---
base-commit: 706a741595047797872e669b3101429ab8d378ef
change-id: 20230830-smccc_export-aa68d8a25539

Best regards,
--
Martin Botka <[email protected]>

2023-08-31 00:16:32

by Marc Zyngier

Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions

On 2023-08-30 14:23, Martin Botka wrote:
> arm_smccc_get_soc_id_version and arm_smccc_get_soc_id_revision
> need to be exported so they can be used by modules.
> Currently sun50i cpu freq driver is planning to use these functions.
>

What for? I'm absolutely not keen on randomly exporting synbols
until we see what this is for.

Thanks,

M.
--
Jazz is not dead. It just smells funny...