2023-08-30 18:34:07

by SeongJae Park

[permalink] [raw]
Subject: Re: [RFC PATCH] mm/damon/core: add a tracepoint for damos apply target regions

Hi Steven,

On Tue, 29 Aug 2023 19:16:29 -0400 Steven Rostedt <[email protected]> wrote:

> On Sun, 27 Aug 2023 00:40:45 +0000
> SeongJae Park <[email protected]> wrote:
>
> > + TP_STRUCT__entry(
> > + __field(unsigned int, context_idx)
>
> 4 bytes
>
> > + __field(unsigned int, scheme_idx)
>
> 4 bytes
>
> > + __field(unsigned long, target_idx)
>
> 8 bytes
>
> > + __field(unsigned int, nr_regions)
>
> 4 bytes
>
> > + __field(unsigned long, start)
>
> This is going to cause a 4 byte hole. I would move nr_regions after end
> so that it stays properly aligned.

That makes sense, thank you for letting me know this! I will do so in the next
spin.


Thanks,
SJ

>
> -- Steve
>
>
>
> > + __field(unsigned long, end)
> > + __field(unsigned int, nr_accesses)
> > + __field(unsigned int, age)
> > + ),
> > +
>