On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> Reading thermal sensor on mt7986 devices returns invalid temperature:
>
> bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
> -274000
>
> Fix this by adding missing members in mtk_thermal_data struct which were
> used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
>
> Cc: [email protected]
> Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> Signed-off-by: Frank Wunderlich <[email protected]>
Reviewed-by: Markus Schneider-Pargmann <[email protected]>
Thanks for fixing!
Best,
Markus
> ---
> drivers/thermal/mediatek/auxadc_thermal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> index 843214d30bd8..967b9a1aead4 100644
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = {
> .adcpnp = mt7986_adcpnp,
> .sensor_mux_values = mt7986_mux_values,
> .version = MTK_THERMAL_V3,
> + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1,
> + .apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3),
> + .apmixed_buffer_ctl_set = BIT(0),
> };
>
> static bool mtk_thermal_temp_is_valid(int temp)
> --
> 2.34.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi everyone!
On Wed, Sep 13, 2023 at 10:35:29AM +0200, Markus Schneider-Pargmann wrote:
> On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <[email protected]>
> >
> > Reading thermal sensor on mt7986 devices returns invalid temperature:
> >
> > bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
> > -274000
> >
> > Fix this by adding missing members in mtk_thermal_data struct which were
> > used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
> >
> > Cc: [email protected]
> > Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> > Signed-off-by: Frank Wunderlich <[email protected]>
>
> Reviewed-by: Markus Schneider-Pargmann <[email protected]>
Reviewed-by: Daniel Golle <[email protected]>
Tested-by: Daniel Golle <[email protected]>
Kind ping to thermal and mediatek maintainers, please merge this patch.
https://patchwork.kernel.org/project/linux-pm/patch/[email protected]/
https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
>
> Thanks for fixing!
>
> Best,
> Markus
>
> > ---
> > drivers/thermal/mediatek/auxadc_thermal.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> > index 843214d30bd8..967b9a1aead4 100644
> > --- a/drivers/thermal/mediatek/auxadc_thermal.c
> > +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> > @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = {
> > .adcpnp = mt7986_adcpnp,
> > .sensor_mux_values = mt7986_mux_values,
> > .version = MTK_THERMAL_V3,
> > + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1,
> > + .apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3),
> > + .apmixed_buffer_ctl_set = BIT(0),
> > };
> >
> > static bool mtk_thermal_temp_is_valid(int temp)
> > --
> > 2.34.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
On 31/01/2024 06:17, Daniel Golle wrote:
> Hi everyone!
>
> On Wed, Sep 13, 2023 at 10:35:29AM +0200, Markus Schneider-Pargmann wrote:
>> On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <[email protected]>
>>>
>>> Reading thermal sensor on mt7986 devices returns invalid temperature:
>>>
>>> bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
>>> -274000
>>>
>>> Fix this by adding missing members in mtk_thermal_data struct which were
>>> used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
>>>
>>> Cc: [email protected]
>>> Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
>>> Signed-off-by: Frank Wunderlich <[email protected]>
>>
>> Reviewed-by: Markus Schneider-Pargmann <[email protected]>
>
> Reviewed-by: Daniel Golle <[email protected]>
> Tested-by: Daniel Golle <[email protected]>
>
> Kind ping to thermal and mediatek maintainers, please merge this patch.
Applied with master pong
Thanks!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog