2023-09-14 14:56:35

by Usyskin, Alexander

[permalink] [raw]
Subject: [PATCH v2 0/4] drm/xe/gsc: add initial gsc support

Add initial GSC support for DG1 and DG2.
Create mei-gscfi auxiliary device and add
support for device created by Xe to the mei-gsc driver.

This series intended to be merged intto Xe tree,
the only patch that touches char-misc is addition
of id and alias in mei-gsc.

V2: Added heci_ to struct and APIs
heci_gsc moved under xe_device as GSC is not under GT

Signed-off-by: Alexander Usyskin <[email protected]>

Vitaly Lubart (4):
drm/xe/gsc: add HECI2 register offsets
drm/xe/gsc: add has_heci_gscfi indication to device
drm/xe/gsc: add gsc device support
mei: gsc: add support for auxiliary device created by Xe driver

drivers/gpu/drm/xe/Kconfig | 1 +
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/regs/xe_regs.h | 4 +
drivers/gpu/drm/xe/xe_device.c | 4 +
drivers/gpu/drm/xe/xe_device_types.h | 7 +
drivers/gpu/drm/xe/xe_heci_gsc.c | 205 +++++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_heci_gsc.h | 35 +++++
drivers/gpu/drm/xe/xe_irq.c | 14 +-
drivers/gpu/drm/xe/xe_pci.c | 9 +-
drivers/misc/mei/gsc-me.c | 5 +
10 files changed, 281 insertions(+), 4 deletions(-)
create mode 100644 drivers/gpu/drm/xe/xe_heci_gsc.c
create mode 100644 drivers/gpu/drm/xe/xe_heci_gsc.h

--
2.34.1


2023-09-18 17:37:51

by Rodrigo Vivi

[permalink] [raw]
Subject: Re: [Intel-xe] [PATCH v2 0/4] drm/xe/gsc: add initial gsc support

On Thu, Sep 14, 2023 at 11:01:34AM +0300, Alexander Usyskin wrote:
> Add initial GSC support for DG1 and DG2.
> Create mei-gscfi auxiliary device and add
> support for device created by Xe to the mei-gsc driver.

why are we not adding the GSC already? because dependency on the GSC
engine or something like that?

>
> This series intended to be merged intto Xe tree,
> the only patch that touches char-misc is addition
> of id and alias in mei-gsc.
>
> V2: Added heci_ to struct and APIs
> heci_gsc moved under xe_device as GSC is not under GT
>
> Signed-off-by: Alexander Usyskin <[email protected]>
>
> Vitaly Lubart (4):
> drm/xe/gsc: add HECI2 register offsets
> drm/xe/gsc: add has_heci_gscfi indication to device
> drm/xe/gsc: add gsc device support
> mei: gsc: add support for auxiliary device created by Xe driver
>
> drivers/gpu/drm/xe/Kconfig | 1 +
> drivers/gpu/drm/xe/Makefile | 1 +
> drivers/gpu/drm/xe/regs/xe_regs.h | 4 +
> drivers/gpu/drm/xe/xe_device.c | 4 +
> drivers/gpu/drm/xe/xe_device_types.h | 7 +
> drivers/gpu/drm/xe/xe_heci_gsc.c | 205 +++++++++++++++++++++++++++
> drivers/gpu/drm/xe/xe_heci_gsc.h | 35 +++++
> drivers/gpu/drm/xe/xe_irq.c | 14 +-
> drivers/gpu/drm/xe/xe_pci.c | 9 +-
> drivers/misc/mei/gsc-me.c | 5 +
> 10 files changed, 281 insertions(+), 4 deletions(-)
> create mode 100644 drivers/gpu/drm/xe/xe_heci_gsc.c
> create mode 100644 drivers/gpu/drm/xe/xe_heci_gsc.h
>
> --
> 2.34.1
>

2023-09-20 08:57:08

by Usyskin, Alexander

[permalink] [raw]
Subject: RE: [Intel-xe] [PATCH v2 0/4] drm/xe/gsc: add initial gsc support



> -----Original Message-----
> From: Vivi, Rodrigo <[email protected]>
> Sent: Monday, September 18, 2023 19:07
> To: Usyskin, Alexander <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>; De Marchi, Lucas
> <[email protected]>; Ceraolo Spurio, Daniele
> <[email protected]>; [email protected]; Winkler,
> Tomas <[email protected]>; [email protected]
> Subject: Re: [Intel-xe] [PATCH v2 0/4] drm/xe/gsc: add initial gsc support
>
> On Thu, Sep 14, 2023 at 11:01:34AM +0300, Alexander Usyskin wrote:
> > Add initial GSC support for DG1 and DG2.
> > Create mei-gscfi auxiliary device and add
> > support for device created by Xe to the mei-gsc driver.
>
> why are we not adding the GSC already? because dependency on the GSC
> engine or something like that?
>

The DG1 and DG2 have only HECI-GSC routed via mei.
The pure GSC without mei is for later projects.

--
Thanks,
Sasha


> >
> > This series intended to be merged intto Xe tree,
> > the only patch that touches char-misc is addition
> > of id and alias in mei-gsc.
> >
> > V2: Added heci_ to struct and APIs
> > heci_gsc moved under xe_device as GSC is not under GT
> >
> > Signed-off-by: Alexander Usyskin <[email protected]>
> >
> > Vitaly Lubart (4):
> > drm/xe/gsc: add HECI2 register offsets
> > drm/xe/gsc: add has_heci_gscfi indication to device
> > drm/xe/gsc: add gsc device support
> > mei: gsc: add support for auxiliary device created by Xe driver
> >
> > drivers/gpu/drm/xe/Kconfig | 1 +
> > drivers/gpu/drm/xe/Makefile | 1 +
> > drivers/gpu/drm/xe/regs/xe_regs.h | 4 +
> > drivers/gpu/drm/xe/xe_device.c | 4 +
> > drivers/gpu/drm/xe/xe_device_types.h | 7 +
> > drivers/gpu/drm/xe/xe_heci_gsc.c | 205
> +++++++++++++++++++++++++++
> > drivers/gpu/drm/xe/xe_heci_gsc.h | 35 +++++
> > drivers/gpu/drm/xe/xe_irq.c | 14 +-
> > drivers/gpu/drm/xe/xe_pci.c | 9 +-
> > drivers/misc/mei/gsc-me.c | 5 +
> > 10 files changed, 281 insertions(+), 4 deletions(-)
> > create mode 100644 drivers/gpu/drm/xe/xe_heci_gsc.c
> > create mode 100644 drivers/gpu/drm/xe/xe_heci_gsc.h
> >
> > --
> > 2.34.1
> >