2023-09-15 11:51:52

by Chen Wang

Subject: [PATCH 09/12] dt-bindings: serial: snps-dw-apb-uart: Add Sophgo SG2042 uarts

From: Emil Renner Berthing <[email protected]>

Add compatible for the uarts on the Sophgo SG2042 RISC-V SoC.

Signed-off-by: Emil Renner Berthing <[email protected]>
---
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
index 17c553123f96..6c23562f1b1e 100644
--- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
@@ -48,6 +48,9 @@ properties:
- starfive,jh7100-hsuart
- starfive,jh7100-uart
- const: snps,dw-apb-uart
+ - items:
+ - const: sophgo,sg2042-uart
+ - const: snps,dw-apb-uart
- const: snps,dw-apb-uart

reg:
--
2.25.1

2023-09-15 16:48:54

by Krzysztof Kozlowski

Subject: Re: [PATCH 09/12] dt-bindings: serial: snps-dw-apb-uart: Add Sophgo SG2042 uarts

On 15/09/2023 09:25, Wang Chen wrote:
> From: Emil Renner Berthing <[email protected]>
>
> Add compatible for the uarts on the Sophgo SG2042 RISC-V SoC.
>
> Signed-off-by: Emil Renner Berthing <[email protected]>

Missing Sob.

> ---
> Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> index 17c553123f96..6c23562f1b1e 100644
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -48,6 +48,9 @@ properties:
> - starfive,jh7100-hsuart
> - starfive,jh7100-uart
> - const: snps,dw-apb-uart
> + - items:
> + - const: sophgo,sg2042-uart

No, you do not get your own entry. Stuff it into previous enum.



Best regards,
Krzysztof

2023-09-18 22:51:41

by Krzysztof Kozlowski

Subject: Re: [PATCH 09/12] dt-bindings: serial: snps-dw-apb-uart: Add Sophgo SG2042 uarts

On 18/09/2023 14:49, Chen Wang wrote:
> Hi, Krzysztof,
>
> I see Emil has clarified in anther email, I copy it here for your quick
> reference:
>
> >Sophgo and StarFive are not the same company. Sophgo are using RISC-V
> cores from T-Head and StarFive are using cores from SiFive.
>
> And SG2042 is chip from Sophgo, and JH7100 is chip from StarFive.
>
> So I think it should be better to use a new entry for sg2042, what do
> you think?

We talked about different things. Previous discussion was about
compatibility. Here, you should just not create your own enum, because
there is no single need. Just put it to previous enum.

Best regards,
Krzysztof