2023-09-15 09:49:48

by Anshuman Khandual

Subject: [PATCH V5 - RESEND 3/3] Documentation: coresight: Add cc_threshold tunable

This updates config option to include 'cc_threshold' tunable value.

Cc: Suzuki K Poulose <[email protected]>
Cc: Mike Leach <[email protected]>
Cc: James Clark <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Reviewed by: Mike Leach <[email protected]>
Signed-off-by: Anshuman Khandual <[email protected]>
---
Documentation/trace/coresight/coresight.rst | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/trace/coresight/coresight.rst b/Documentation/trace/coresight/coresight.rst
index 4a71ea6cb390..ce55adb80b82 100644
--- a/Documentation/trace/coresight/coresight.rst
+++ b/Documentation/trace/coresight/coresight.rst
@@ -624,6 +624,10 @@ They are also listed in the folder /sys/bus/event_source/devices/cs_etm/format/
* - timestamp
- Session local version of the system wide setting: :ref:`ETMv4_MODE_TIMESTAMP
<coresight-timestamp>`
+ * - cc_threshold
+ - Cycle count threshold value. If nothing is provided here or the provided value is 0, then the
+ default value i.e 0x100 will be used. If provided value is less than minimum cycles threshold
+ value, as indicated via TRCIDR3.CCITMIN, then the minimum value will be used instead.

How to use the STM module
-------------------------
--
2.25.1

2023-09-20 09:45:36

by Suzuki K Poulose

Subject: Re: [PATCH V5 - RESEND 3/3] Documentation: coresight: Add cc_threshold tunable

On 15/09/2023 10:36, Anshuman Khandual wrote:
> This updates config option to include 'cc_threshold' tunable value.
>
> Cc: Suzuki K Poulose <[email protected]>
> Cc: Mike Leach <[email protected]>
> Cc: James Clark <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Reviewed by: Mike Leach <[email protected]>
> Signed-off-by: Anshuman Khandual <[email protected]>
> ---
> Documentation/trace/coresight/coresight.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/trace/coresight/coresight.rst b/Documentation/trace/coresight/coresight.rst
> index 4a71ea6cb390..ce55adb80b82 100644
> --- a/Documentation/trace/coresight/coresight.rst
> +++ b/Documentation/trace/coresight/coresight.rst
> @@ -624,6 +624,10 @@ They are also listed in the folder /sys/bus/event_source/devices/cs_etm/format/
> * - timestamp
> - Session local version of the system wide setting: :ref:`ETMv4_MODE_TIMESTAMP
> <coresight-timestamp>`
> + * - cc_threshold
> + - Cycle count threshold value. If nothing is provided here or the provided value is 0, then the
> + default value i.e 0x100 will be used. If provided value is less than minimum cycles threshold
> + value, as indicated via TRCIDR3.CCITMIN, then the minimum value will be used instead.
>
> How to use the STM module
> -------------------------

The patch as such looks good to me. If possible, could you fold this
into the previous patch ?

Suzuki

2023-09-20 10:53:22

by Anshuman Khandual

Subject: Re: [PATCH V5 - RESEND 3/3] Documentation: coresight: Add cc_threshold tunable

On 9/20/23 14:55, Suzuki K Poulose wrote:
> On 15/09/2023 10:36, Anshuman Khandual wrote:
>> This updates config option to include 'cc_threshold' tunable value.
>>
>> Cc: Suzuki K Poulose <[email protected]>
>> Cc: Mike Leach <[email protected]>
>> Cc: James Clark <[email protected]>
>> Cc: Jonathan Corbet <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Reviewed by: Mike Leach <[email protected]>
>> Signed-off-by: Anshuman Khandual <[email protected]>
>> ---
>>   Documentation/trace/coresight/coresight.rst | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/trace/coresight/coresight.rst b/Documentation/trace/coresight/coresight.rst
>> index 4a71ea6cb390..ce55adb80b82 100644
>> --- a/Documentation/trace/coresight/coresight.rst
>> +++ b/Documentation/trace/coresight/coresight.rst
>> @@ -624,6 +624,10 @@ They are also listed in the folder /sys/bus/event_source/devices/cs_etm/format/
>>      * - timestamp
>>        - Session local version of the system wide setting: :ref:`ETMv4_MODE_TIMESTAMP
>>          <coresight-timestamp>`
>> +   * - cc_threshold
>> +     - Cycle count threshold value. If nothing is provided here or the provided value is 0, then the
>> +       default value i.e 0x100 will be used. If provided value is less than minimum cycles threshold
>> +       value, as indicated via TRCIDR3.CCITMIN, then the minimum value will be used instead.
>>     How to use the STM module
>>   -------------------------
>
> The patch as such looks good to me. If possible, could you fold this into the previous patch ?

Being a documentation update, may be it's better to have this in a separate patch.