2023-09-18 12:06:54

by Arınç ÜNAL

Subject: [PATCH] arm: dts: replace Bananapi with Banana Pi

The brand name is Banana Pi. Replace any mention of Bananapi with Banana
Pi.

Signed-off-by: Arınç ÜNAL <[email protected]>
---
arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi | 2 +-
arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
index 235994a4a2eb..ef532494fc9d 100644
--- a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
+++ b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
@@ -7,7 +7,7 @@

/ {
/*
- * Bananapi M2+ v1.2 uses a GPIO line to change the effective
+ * Banana Pi BPI-M2+ v1.2 uses a GPIO line to change the effective
* resistance on the CPU regulator's feedback pin.
*/
reg_vdd_cpux: vdd-cpux {
diff --git a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
index a37f3fa223c7..7f0948074945 100644
--- a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
+++ b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
@@ -10,7 +10,7 @@
#include "mt6323.dtsi"

/ {
- model = "Bananapi BPI-R2";
+ model = "Banana Pi BPI-R2";
compatible = "bananapi,bpi-r2", "mediatek,mt7623";

aliases {
--
2.39.2

2023-09-19 12:24:54

by Andre Przywara

Subject: Re: [PATCH] arm: dts: replace Bananapi with Banana Pi

On Mon, 18 Sep 2023 10:41:22 +0300
Arınç ÜNAL <[email protected]> wrote:

Hi,

> The brand name is Banana Pi. Replace any mention of Bananapi with Banana
> Pi.

So in general this looks fine, and the comment change is surely a
no-brainer. But I was wondering if changing the model name is something
that should be done, as there might be someone relying on that?
And if we go there: "git grep" finds a number of boards using "Bananapi",
and some others with "BananaPi", so I guess those should be changed then
as well?

Cheers,
Andre.

>
> Signed-off-by: Arınç ÜNAL <[email protected]>
> ---
> arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi | 2 +-
> arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> index 235994a4a2eb..ef532494fc9d 100644
> --- a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> +++ b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> @@ -7,7 +7,7 @@
>
> / {
> /*
> - * Bananapi M2+ v1.2 uses a GPIO line to change the effective
> + * Banana Pi BPI-M2+ v1.2 uses a GPIO line to change the effective
> * resistance on the CPU regulator's feedback pin.
> */
> reg_vdd_cpux: vdd-cpux {
> diff --git a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> index a37f3fa223c7..7f0948074945 100644
> --- a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> @@ -10,7 +10,7 @@
> #include "mt6323.dtsi"
>
> / {
> - model = "Bananapi BPI-R2";
> + model = "Banana Pi BPI-R2";
> compatible = "bananapi,bpi-r2", "mediatek,mt7623";
>
> aliases {