On Thu, Sep 21, 2023, [email protected] wrote:
> From: Isaku Yamahata <[email protected]>
>
> This patch series is to implement test cases for the KVM gmem error_remove_page
> method.
> - Update punch hole method to truncate pages
> - Add a new ioctl KVM_GUEST_MEMORY_FAILURE to inject memory failure on
> offset of gmem
Doh. Please try to communicate what you're working on. I was just about to hit
SEND on a series to fix the truncation bug, and to add a similar test. I would
have happily punted that in your direction, but I had no idea that you were aware
of the bug[*], let alone working on a fix. I could have explicitly stated that
I was going to fix the bug, but I thought that it was implied that I needed to
clean up my own mess.
Anyways, I'm going to hit SEND anyways, my changes are slightly different to your
patch 1 (truncate needs to happen between begin() and end()) and patch 3 (I added
a slightly more comprehensive test).
[*] https://lore.kernel.org/all/[email protected]
On Thu, Sep 21, 2023 at 01:29:59PM -0700,
Sean Christopherson <[email protected]> wrote:
> On Thu, Sep 21, 2023, [email protected] wrote:
> > From: Isaku Yamahata <[email protected]>
> >
> > This patch series is to implement test cases for the KVM gmem error_remove_page
> > method.
> > - Update punch hole method to truncate pages
> > - Add a new ioctl KVM_GUEST_MEMORY_FAILURE to inject memory failure on
> > offset of gmem
>
> Doh. Please try to communicate what you're working on. I was just about to hit
> SEND on a series to fix the truncation bug, and to add a similar test. I would
> have happily punted that in your direction, but I had no idea that you were aware
> of the bug[*], let alone working on a fix. I could have explicitly stated that
> I was going to fix the bug, but I thought that it was implied that I needed to
> clean up my own mess.
Oops sorry. Now I'm considering about machine check injection.
i.e. somehow trigger kvm_machine_check() and its own test cases.
--
Isaku Yamahata <[email protected]>