2023-09-26 02:25:13

by Li kunyu

Subject: [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts

ucounts is assigned first, so it does not need to initialize the
assignment.

Signed-off-by: Li kunyu <[email protected]>
---
kernel/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 09019017d669..27f6cd37ac4f 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -415,7 +415,7 @@ __sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags,
int override_rlimit, const unsigned int sigqueue_flags)
{
struct sigqueue *q = NULL;
- struct ucounts *ucounts = NULL;
+ struct ucounts *ucounts;
long sigpending;

/*
--
2.18.2

2023-09-26 23:08:59

by Oleg Nesterov

Subject: Re: [PATCH] kernel/signal: Remov e unnecessary ‘NULL’ values from ucounts

On 09/26, Li kunyu wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -415,7 +415,7 @@ __sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags,
> int override_rlimit, const unsigned int sigqueue_flags)
> {
> struct sigqueue *q = NULL;
> - struct ucounts *ucounts = NULL;
> + struct ucounts *ucounts;
> long sigpending;

this looks obviously correct, so

Acked-by: Oleg Nesterov <[email protected]>


but you know, this change is so trivial, perhaps you should
resend this minor cleanup to [email protected]

but let me add Andrew, perhaps he will take this patch...

Oleg.