2023-08-20 12:16:32

by Andreas Kemnade

[permalink] [raw]
Subject: [PATCH] ARM: dts: omap4: embt2ws: add LED

Add LED since the driver is now available.

Signed-off-by: Andreas Kemnade <[email protected]>
---
.../boot/dts/ti/omap/omap4-epson-embt2ws.dts | 27 ++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
index e119e2cccc4e1..f47d330fb6ee4 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
@@ -4,6 +4,7 @@
*/
/dts-v1/;

+#include <dt-bindings/leds/common.h>
#include <dt-bindings/input/input.h>
#include "omap4460.dtsi"

@@ -206,7 +207,31 @@ &i2c3 {

clock-frequency = <100000>;

- /* TODO: BD2606MVV at 0x66 */
+ led-controller@66 {
+ compatible = "rohm,bd2606mvv";
+ reg = <0x66>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@0 {
+ reg = <0>;
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_STATUS;
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_BLUE>;
+ function = LED_FUNCTION_STATUS;
+ };
+
+ led@4 {
+ reg = <4>;
+ color = <LED_COLOR_ID_RED>;
+ function = LED_FUNCTION_STATUS;
+ };
+ };
};

&i2c4 {
--
2.39.2



2023-09-26 07:28:23

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: omap4: embt2ws: add LED

* Andreas Kemnade <[email protected]> [230819 17:31]:
> Add LED since the driver is now available.

Thanks applying into omap-for-v6.7/dt.

Tony

2023-10-31 09:16:54

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: omap4: embt2ws: add LED

Hi!

> Add LED since the driver is now available.
>
> Signed-off-by: Andreas Kemnade <[email protected]>

Is it one LED or three LEDs?

If it is one, we should use multicolor...

BR,
Pavel

> @@ -206,7 +207,31 @@ &i2c3 {
>
> clock-frequency = <100000>;
>
> - /* TODO: BD2606MVV at 0x66 */
> + led-controller@66 {
> + compatible = "rohm,bd2606mvv";
> + reg = <0x66>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_STATUS;
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_STATUS;
> + };
> +
> + led@4 {
> + reg = <4>;
> + color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_STATUS;
> + };
> + };
> };
>
> &i2c4 {

--
People of Russia, stop Putin before his war on Ukraine escalates.

Attachments:
(No filename) (946.00 B)
 signature.asc (201.00 B)
 Download all attachments