From: Wedson Almeida Filho <[email protected]>
A mistake was made and the description of `ECHILD` is wrong (it reuses
the description of `ENOEXEC`). This fixes it to reflect what's in
`errno-base.h`.
Signed-off-by: Wedson Almeida Filho <[email protected]>
---
rust/kernel/error.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
index 05fcab6abfe6..bab2c043fc42 100644
--- a/rust/kernel/error.rs
+++ b/rust/kernel/error.rs
@@ -37,7 +37,7 @@ macro_rules! declare_err {
declare_err!(E2BIG, "Argument list too long.");
declare_err!(ENOEXEC, "Exec format error.");
declare_err!(EBADF, "Bad file number.");
- declare_err!(ECHILD, "Exec format error.");
+ declare_err!(ECHILD, "No child process.");
declare_err!(EAGAIN, "Try again.");
declare_err!(ENOMEM, "Out of memory.");
declare_err!(EACCES, "Permission denied.");
base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
--
2.34.1
On 9/30/23 11:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <[email protected]>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <[email protected]>
> ---
> [...]
Reviewed-by: Martin Rodriguez Reboredo <[email protected]>
On Sat, Sep 30, 2023 at 10:50 AM Wedson Almeida Filho
<[email protected]> wrote:
>
> From: Wedson Almeida Filho <[email protected]>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <[email protected]>
> ---
Reviewed-by: Trevor Gross <[email protected]>
On 9/30/23 16:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <[email protected]>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <[email protected]>
> ---
> rust/kernel/error.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Alice Ryhl <[email protected]>
On 30 Sep 2023, at 16:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <[email protected]>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <[email protected]>
> ---
Reviewed-by: Finn Behrens <[email protected]>
On Sat, Sep 30, 2023 at 4:50 PM Wedson Almeida Filho <[email protected]> wrote:
>
> From: Wedson Almeida Filho <[email protected]>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <[email protected]>
Applied to `rust-fixes`, thanks everyone!
Cheers,
Miguel
On 30.09.23 16:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <[email protected]>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <[email protected]>
> ---
> rust/kernel/error.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05fcab6abfe6..bab2c043fc42 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -37,7 +37,7 @@ macro_rules! declare_err {
> declare_err!(E2BIG, "Argument list too long.");
> declare_err!(ENOEXEC, "Exec format error.");
> declare_err!(EBADF, "Bad file number.");
> - declare_err!(ECHILD, "Exec format error.");
> + declare_err!(ECHILD, "No child process.");
Strictly speaking, `errno-base.h` documents this as "No child
processes" (note the plural), but I am fine with taking it as-is.
Reviewed-by: Benno Lossin <[email protected]>
On Mon, Oct 9, 2023 at 4:54 PM Benno Lossin <[email protected]> wrote:
>
> Strictly speaking, `errno-base.h` documents this as "No child
> processes" (note the plural), but I am fine with taking it as-is.
Good catch.
POSIX seems to use both (General Information vs. `<errno.h>`), so
perhaps that is where Wedson picked it from.
Given the kernel uses the plural, and that the commit message says it
mimics `errno-base.h`, I have amended it.
Cheers,
Miguel
1: 77983c791960 ! 1: 17bfcd6a8153 rust: error: fix the description
for `ECHILD`
@@ Commit message
Fixes: 266def2a0f5b ("rust: error: add codes from `errno-base.h`")
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
+ [ Use the plural, as noticed by Benno. ]
Signed-off-by: Miguel Ojeda <[email protected]>
## rust/kernel/error.rs ##
@@ rust/kernel/error.rs: macro_rules! declare_err {
declare_err!(ENOEXEC, "Exec format error.");
declare_err!(EBADF, "Bad file number.");
- declare_err!(ECHILD, "Exec format error.");
-+ declare_err!(ECHILD, "No child process.");
++ declare_err!(ECHILD, "No child processes.");
declare_err!(EAGAIN, "Try again.");
declare_err!(ENOMEM, "Out of memory.");
declare_err!(EACCES, "Permission denied.");