2023-10-01 18:36:04

by April John

Subject: [PATCH] /bin/dmesg to dmesg Path

Dmesg is not in every distro at /bin/dmesg, in NixOS for example, this fails,
but the path should in most cases contain dmesg.
This follows the example of replacing /bin/bash with bash Path in the codebase.

---
tools/perf/util/evsel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index a8a5ff87c..aa602aae6 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -3053,7 +3053,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,

return scnprintf(msg, size,
"The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
- "/bin/dmesg | grep -i perf may provide additional information.\n",
+ "dmesg | grep -i perf may provide additional information.\n",
err, str_error_r(err, sbuf, sizeof(sbuf)), evsel__name(evsel));
}

--
2.42.0

Signed-off-by: April John <[email protected]>

2023-10-03 04:17:07

by Namhyung Kim

Subject: Re: [PATCH] /bin/dmesg to dmesg Path

Hello,

On Sun, Oct 1, 2023 at 6:10 AM April John <[email protected]> wrote:
>
> Dmesg is not in every distro at /bin/dmesg, in NixOS for example, this fails,
> but the path should in most cases contain dmesg.
> This follows the example of replacing /bin/bash with bash Path in the codebase.
>
> ---
> tools/perf/util/evsel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index a8a5ff87c..aa602aae6 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -3053,7 +3053,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
>
> return scnprintf(msg, size,
> "The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
> - "/bin/dmesg | grep -i perf may provide additional information.\n",
> + "dmesg | grep -i perf may provide additional information.\n",
> err, str_error_r(err, sbuf, sizeof(sbuf)), evsel__name(evsel));
> }
>
> --
> 2.42.0
>
> Signed-off-by: April John <[email protected]>

It is usual to put a tag after the patch, it should be at the end of the
commit message. With that,

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung

2023-10-05 16:58:23

by Namhyung Kim

Subject: Re: [PATCH] /bin/dmesg to dmesg Path

On Mon, Oct 2, 2023 at 9:16 PM Namhyung Kim <[email protected]> wrote:
>
> Hello,
>
> On Sun, Oct 1, 2023 at 6:10 AM April John <[email protected]> wrote:
> >
> > Dmesg is not in every distro at /bin/dmesg, in NixOS for example, this fails,
> > but the path should in most cases contain dmesg.
> > This follows the example of replacing /bin/bash with bash Path in the codebase.
> >
> > ---
> > tools/perf/util/evsel.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> > index a8a5ff87c..aa602aae6 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -3053,7 +3053,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
> >
> > return scnprintf(msg, size,
> > "The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
> > - "/bin/dmesg | grep -i perf may provide additional information.\n",
> > + "dmesg | grep -i perf may provide additional information.\n",
> > err, str_error_r(err, sbuf, sizeof(sbuf)), evsel__name(evsel));
> > }
> >
> > --
> > 2.42.0
> >
> > Signed-off-by: April John <[email protected]>
>
> It is usual to put a tag after the patch, it should be at the end of the
> commit message. With that,
>
> Acked-by: Namhyung Kim <[email protected]>

I've tried to apply the patch but it failed. It looks broken.
Have you generated it using git format-patch ?

Thanks,
Namhyung


Applying: /bin/dmesg to dmesg Path
error: corrupt patch at line 11
Patch failed at 0001 /bin/dmesg to dmesg Path