2023-10-08 14:22:43

by Ondřej Jirman

[permalink] [raw]
Subject: [PATCH] dt-bindings: mfd: rk806: Allow rockchip,system-power-controller property

From: Ondrej Jirman <[email protected]>

Declare support for this property.

Signed-off-by: Ondrej Jirman <[email protected]>
---
Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
index cf2500f2e9a0..e8c9f17f6ea8 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
@@ -29,6 +29,11 @@ properties:
'#gpio-cells':
const: 2

+ rockchip,system-power-controller:
+ type: boolean
+ description:
+ Telling whether or not this PMIC is controlling the system power.
+
vcc1-supply:
description:
The input supply for dcdc-reg1.
--
2.42.0


2023-10-08 19:02:22

by Ondřej Jirman

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mfd: rk806: Allow rockchip,system-power-controller property

On Sun, Oct 08, 2023 at 08:55:59PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Sun, Oct 08, 2023 at 04:21:17PM +0200, Ondřej Jirman wrote:
> > From: Ondrej Jirman <[email protected]>
> >
> > Declare support for this property.
> >
> > Signed-off-by: Ondrej Jirman <[email protected]>
> > ---
>
> This is missing the accompanying driver change. Right now
> this property does nothing for rk806.

Ah, I assumed it does, but looks like it's just implemented in my tree:

https://megous.com/git/linux/commit/?h=ppp-drivers-6.6&id=6394918f339fda0b89f63faac4c4fe162d5ace42

I'll re-send with the driver patch.

Thanks and regards,
o.


> -- Sebastian
>
> > Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > index cf2500f2e9a0..e8c9f17f6ea8 100644
> > --- a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > @@ -29,6 +29,11 @@ properties:
> > '#gpio-cells':
> > const: 2
> >
> > + rockchip,system-power-controller:
> > + type: boolean
> > + description:
> > + Telling whether or not this PMIC is controlling the system power.
> > +
> > vcc1-supply:
> > description:
> > The input supply for dcdc-reg1.
> > --
> > 2.42.0
> >


2023-10-08 19:02:43

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mfd: rk806: Allow rockchip,system-power-controller property

Hi,

On Sun, Oct 08, 2023 at 04:21:17PM +0200, Ondřej Jirman wrote:
> From: Ondrej Jirman <[email protected]>
>
> Declare support for this property.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---

This is missing the accompanying driver change. Right now
this property does nothing for rk806.

-- Sebastian

> Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> index cf2500f2e9a0..e8c9f17f6ea8 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> @@ -29,6 +29,11 @@ properties:
> '#gpio-cells':
> const: 2
>
> + rockchip,system-power-controller:
> + type: boolean
> + description:
> + Telling whether or not this PMIC is controlling the system power.
> +
> vcc1-supply:
> description:
> The input supply for dcdc-reg1.
> --
> 2.42.0
>

Attachments:
(No filename) (1.07 kB)
 signature.asc (849.00 B)
 Download all attachments