2023-10-10 20:44:35

by Ninad Palsule

Subject: [PATCH v3 1/2] fsi: sbefifo: Bump up user write cmd length

This commit increases user write limit for command length from 1MB to
4MB. This is required to support images larger than 1MB.

As per 'commit 15e2a7218c27 ("fsi: sbefifo: Bump max command length")'
the alternate solution is to break image into 1MB pieces by cronous
server that means kernel driver needs to provide way to send end of
message command once all pieces are transferred. This requires
restructuring of both kernel driver and cronus server (application).
Hence this commit chose to bump up cmd length to reduce code impact.

Testing:
Loaded 3 MB image through cronus server.

Signed-off-by: Ninad Palsule <[email protected]>
---
v2:
- Add the cmd length check back and changed it to 4MB
---
drivers/fsi/fsi-sbefifo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index 9912b7a6a4b9a..a95b32461f8f3 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -113,7 +113,7 @@ enum sbe_state
#define SBEFIFO_TIMEOUT_IN_RSP 1000

/* Other constants */
-#define SBEFIFO_MAX_USER_CMD_LEN (0x100000 + PAGE_SIZE)
+#define SBEFIFO_MAX_USER_CMD_LEN (0x400000 + PAGE_SIZE)
#define SBEFIFO_RESET_MAGIC 0x52534554 /* "RSET" */

struct sbefifo {
--
2.39.2

2023-10-11 14:19:08

by Eddie James

Subject: Re: [PATCH v3 1/2] fsi: sbefifo: Bump up user write cmd length

On 10/10/23 15:43, Ninad Palsule wrote:
> This commit increases user write limit for command length from 1MB to
> 4MB. This is required to support images larger than 1MB.
>
> As per 'commit 15e2a7218c27 ("fsi: sbefifo: Bump max command length")'
> the alternate solution is to break image into 1MB pieces by cronous
> server that means kernel driver needs to provide way to send end of
> message command once all pieces are transferred. This requires
> restructuring of both kernel driver and cronus server (application).
> Hence this commit chose to bump up cmd length to reduce code impact.
>
> Testing:
> Loaded 3 MB image through cronus server.


Reviewed-by: Eddie James <[email protected]>


>
> Signed-off-by: Ninad Palsule <[email protected]>
> ---
> v2:
> - Add the cmd length check back and changed it to 4MB
> ---
> drivers/fsi/fsi-sbefifo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 9912b7a6a4b9a..a95b32461f8f3 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -113,7 +113,7 @@ enum sbe_state
> #define SBEFIFO_TIMEOUT_IN_RSP 1000
>
> /* Other constants */
> -#define SBEFIFO_MAX_USER_CMD_LEN (0x100000 + PAGE_SIZE)
> +#define SBEFIFO_MAX_USER_CMD_LEN (0x400000 + PAGE_SIZE)
> #define SBEFIFO_RESET_MAGIC 0x52534554 /* "RSET" */
>
> struct sbefifo {