On Thu, 2023-09-07 at 14:35, Andy Shevchenko wrote:
>On Thu, Sep 07, 2023 at 12:40:49PM +0530, Kartik wrote:
>> Add helper function tegra_fuse_add_lookups() to register Tegra fuse
>> nvmem lookups. So, this can be shared between tegra_fuse_init() and
>> ACPI probe, which is to be introduced later.
>
>...
>
>> +static int tegra_fuse_add_lookups(struct tegra_fuse *fuse)
>> +{
>> + size_t size;
>> +
>> + if (!fuse->soc->lookups)
>> + return 0;
>
>> + size = size_mul(sizeof(*fuse->lookups), fuse->soc->num_lookups);
>> +
>> + fuse->lookups = kmemdup(fuse->soc->lookups, size, GFP_KERNEL);
>> + if (!fuse->lookups)
>> + return -ENOMEM;
>
>Why not introducing kmemdup_array()?
Introduced this in v4.
>
>> + nvmem_add_cell_lookups(fuse->lookups, fuse->soc->num_lookups);
>> +
>> + return 0;
>> +}
>
>...
>
>> + err = tegra_fuse_add_lookups(fuse);
>> + if (err) {
>> + pr_err("failed to add FUSE lookups\n");
>
>Why pr_err() and not dev_err()?
This is called before tegra_fuse_probe in device-tree boot hence the
reason behing using pr_err instead of dev_err.
>
>> + return err;
>> }
>>
>> return 0;
>
>These four lines can be just shortened to
>
> return err;
>
Updated this in v4.
>--
>With Best Regards,
>Andy Shevchenko
Regards,
Kartik