2023-10-12 20:07:31

by Javier Carrasco

Subject: [PATCH 0/2] iio: Add device tree support for silabs,si7005

This series adds device tree support for the IIO humidity sensor si7005
and extends the trivial-devices binding to document the addition.

Signed-off-by: Javier Carrasco <[email protected]>
---
Javier Carrasco (2):
iio: si7005: Add device tree support
dt-bindings: trivial-devices: add silabs,si7005

Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
drivers/iio/humidity/si7005.c | 7 +++++++
2 files changed, 9 insertions(+)
---
base-commit: 401644852d0b2a278811de38081be23f74b5bb04
change-id: 20231012-topic-si7005_devicetree-644b61b62178

Best regards,
--
Javier Carrasco <[email protected]>

2023-10-12 20:07:33

by Javier Carrasco

Subject: [PATCH 1/2] iio: si7005: Add device tree support

This device supports ACPI detection but lacks of the device tree
counterpart. Add device tree support.

Signed-off-by: Javier Carrasco <[email protected]>
---
drivers/iio/humidity/si7005.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/iio/humidity/si7005.c b/drivers/iio/humidity/si7005.c
index ebfb79bc9edc..9465908cc65e 100644
--- a/drivers/iio/humidity/si7005.c
+++ b/drivers/iio/humidity/si7005.c
@@ -169,9 +169,16 @@ static const struct i2c_device_id si7005_id[] = {
};
MODULE_DEVICE_TABLE(i2c, si7005_id);

+static const struct of_device_id si7005_dt_ids[] = {
+ { .compatible = "silabs,si7005" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, si7005_dt_ids);
+
static struct i2c_driver si7005_driver = {
.driver = {
.name = "si7005",
+ .of_match_table = si7005_dt_ids,
},
.probe = si7005_probe,
.id_table = si7005_id,

--
2.39.2

2023-10-14 16:14:31

by Jonathan Cameron

Subject: Re: [PATCH 0/2] iio: Add device tree support for silabs,si7005

On Thu, 12 Oct 2023 22:07:06 +0200
Javier Carrasco <[email protected]> wrote:

> This series adds device tree support for the IIO humidity sensor si7005
> and extends the trivial-devices binding to document the addition.
>
> Signed-off-by: Javier Carrasco <[email protected]>
> ---
> Javier Carrasco (2):
> iio: si7005: Add device tree support
> dt-bindings: trivial-devices: add silabs,si7005
>
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> drivers/iio/humidity/si7005.c | 7 +++++++
> 2 files changed, 9 insertions(+)
> ---
> base-commit: 401644852d0b2a278811de38081be23f74b5bb04
> change-id: 20231012-topic-si7005_devicetree-644b61b62178
>
> Best regards,

Applied to the togreg branch of iiog.it and pushed out as testing for
0-day to take a look at it.

I'll note though that I would expect the fallback path for i2c bindings
to have worked here in which it matches the 'device' bit of the compatible
(ignoring the vendor) with entries in the i2c_device_id table.

I prefer explicit support like you have added here though as that
avoids clashes when different manufacturers use the same part number etc.

Thanks,

Jonathan