2023-10-17 06:20:46

by Li kunyu

Subject: [PATCH] sched: topology: Remove unnecessary ‘0’ values from nr_levels

nr_levels is assigned first, so it does not need to initialize the
assignment.

Signed-off-by: Li kunyu <[email protected]>
---
kernel/sched/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 05a5bc678c089..0ead4e72bc6ca 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1823,7 +1823,7 @@ void sched_init_numa(int offline_node)
{
struct sched_domain_topology_level *tl;
unsigned long *distance_map;
- int nr_levels = 0;
+ int nr_levels;
int i, j;
int *distances;
struct cpumask ***masks;
--
2.18.2

2023-10-18 12:16:01

by Ingo Molnar

Subject: Re: [PATCH] sched: topology: Rem ove unnecessary ‘0’ values from nr_levels

* Li kunyu <[email protected]> wrote:

> nr_levels is assigned first, so it does not need to initialize the
> assignment.

In C there's no such thing as "initializing the assignment"...

Please write sensible changelogs that demonstrate an understanding of these
principles.

Thanks,

Ingo