2023-10-20 05:57:01

by Yiwei Lin

Subject: [PATCH] sched/fair: Remove unused args for pick_next_entity

From: Yiwei Lin <[email protected]>

The arguments 'curr' for pick_next_entity is useless after
the EEVDF changes.

Signed-off-by: Yiwei Lin <[email protected]>
---
kernel/sched/fair.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 9ae220808..486f3c2f5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5256,7 +5256,7 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
* 4) do not run the "skip" process, if something else is available
*/
static struct sched_entity *
-pick_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *curr)
+pick_next_entity(struct cfs_rq *cfs_rq)
{
/*
* Enabling NEXT_BUDDY will affect latency but not fairness.
@@ -8160,7 +8160,7 @@ static struct task_struct *pick_task_fair(struct rq *rq)
goto again;
}

- se = pick_next_entity(cfs_rq, curr);
+ se = pick_next_entity(cfs_rq);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);

@@ -8223,7 +8223,7 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf
}
}

- se = pick_next_entity(cfs_rq, curr);
+ se = pick_next_entity(cfs_rq);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);

@@ -8262,7 +8262,7 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf
put_prev_task(rq, prev);

do {
- se = pick_next_entity(cfs_rq, NULL);
+ se = pick_next_entity(cfs_rq);
set_next_entity(cfs_rq, se);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);
--
2.34.1

2023-10-20 08:10:09

by tip-bot2 for Jacob Pan

Subject: [tip: sched/core] sched/fair: Remove unused 'curr' argument from pick_next_entity()

The following commit has been merged into the sched/core branch of tip:

Commit-ID: 950f26dc82bce4139f762e365843b0338ca6cbfe
Gitweb: https://git.kernel.org/tip/950f26dc82bce4139f762e365843b0338ca6cbfe
Author: Yiwei Lin <[email protected]>
AuthorDate: Fri, 20 Oct 2023 13:56:17 +08:00
Committer: Ingo Molnar <[email protected]>
CommitterDate: Fri, 20 Oct 2023 10:00:55 +02:00

sched/fair: Remove unused 'curr' argument from pick_next_entity()

The 'curr' argument of pick_next_entity() has become unused after
the EEVDF changes.

[ mingo: Updated the changelog. ]

Signed-off-by: Yiwei Lin <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/sched/fair.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 393d0dc..ebee058 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5256,7 +5256,7 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
* 4) do not run the "skip" process, if something else is available
*/
static struct sched_entity *
-pick_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *curr)
+pick_next_entity(struct cfs_rq *cfs_rq)
{
/*
* Enabling NEXT_BUDDY will affect latency but not fairness.
@@ -8160,7 +8160,7 @@ again:
goto again;
}

- se = pick_next_entity(cfs_rq, curr);
+ se = pick_next_entity(cfs_rq);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);

@@ -8223,7 +8223,7 @@ again:
}
}

- se = pick_next_entity(cfs_rq, curr);
+ se = pick_next_entity(cfs_rq);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);

@@ -8262,7 +8262,7 @@ simple:
put_prev_task(rq, prev);

do {
- se = pick_next_entity(cfs_rq, NULL);
+ se = pick_next_entity(cfs_rq);
set_next_entity(cfs_rq, se);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);

2023-10-20 14:02:48

by tip-bot2 for Jacob Pan

Subject: [tip: sched/core] sched/fair: Remove unused 'curr' argument from pick_next_entity()

The following commit has been merged into the sched/core branch of tip:

Commit-ID: 4c456c9ad334a940e354da1002184bc19f4493ef
Gitweb: https://git.kernel.org/tip/4c456c9ad334a940e354da1002184bc19f4493ef
Author: Yiwei Lin <[email protected]>
AuthorDate: Fri, 20 Oct 2023 13:56:17 +08:00
Committer: Ingo Molnar <[email protected]>
CommitterDate: Fri, 20 Oct 2023 15:55:04 +02:00

sched/fair: Remove unused 'curr' argument from pick_next_entity()

The 'curr' argument of pick_next_entity() has become unused after
the EEVDF changes.

[ mingo: Updated the changelog. ]

Signed-off-by: Yiwei Lin <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/sched/fair.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8c486ff..4b70b0d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5256,7 +5256,7 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
* 4) do not run the "skip" process, if something else is available
*/
static struct sched_entity *
-pick_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *curr)
+pick_next_entity(struct cfs_rq *cfs_rq)
{
/*
* Enabling NEXT_BUDDY will affect latency but not fairness.
@@ -8160,7 +8160,7 @@ again:
goto again;
}

- se = pick_next_entity(cfs_rq, curr);
+ se = pick_next_entity(cfs_rq);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);

@@ -8223,7 +8223,7 @@ again:
}
}

- se = pick_next_entity(cfs_rq, curr);
+ se = pick_next_entity(cfs_rq);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);

@@ -8262,7 +8262,7 @@ simple:
put_prev_task(rq, prev);

do {
- se = pick_next_entity(cfs_rq, NULL);
+ se = pick_next_entity(cfs_rq);
set_next_entity(cfs_rq, se);
cfs_rq = group_cfs_rq(se);
} while (cfs_rq);