2023-10-20 09:36:37

by Michael Büsch

[permalink] [raw]
Subject: Re: [PATCH] b43legacy: Removed unneeded variable in debugfs

On Fri, 20 Oct 2023 14:57:35 +0530
Bragatheswaran Manickavel <[email protected]> wrote:

> Removed unneeded variable. Issue identified using Coccinelle semantic.
> No functional impact

This patch is completely wrong. It would not even compile.
Please compile your patches before submitting them!

And it is the second time we see this nonsense.
The code is correct as-is. There is no unused variable.

NACK.

--
Michael Büsch
https://bues.ch/


Attachments:
(No filename) (849.00 B)
OpenPGP digital signature