Every DT property needs a type defined, but "i2c-alias" is missing any
type definition. It's a "uint32", so add a type reference.
Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
index 289737721c2c..0b71e6f911a8 100644
--- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
@@ -69,6 +69,7 @@ properties:
maxItems: 1
i2c-alias:
+ $ref: /schemas/types.yaml#/definitions/uint32
description:
The I2C address used for the serializer. Transactions to this
address on the I2C bus where the deserializer resides are
--
2.42.0
On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> Every DT property needs a type defined, but "i2c-alias" is missing any
> type definition. It's a "uint32", so add a type reference.
>
> Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> Signed-off-by: Rob Herring <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Thanks,
Conor.
> ---
> Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> index 289737721c2c..0b71e6f911a8 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> @@ -69,6 +69,7 @@ properties:
> maxItems: 1
>
> i2c-alias:
> + $ref: /schemas/types.yaml#/definitions/uint32
> description:
> The I2C address used for the serializer. Transactions to this
> address on the I2C bus where the deserializer resides are
> --
> 2.42.0
>
Hi Rob,
Thank you for the patch.
On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> Every DT property needs a type defined, but "i2c-alias" is missing any
> type definition. It's a "uint32", so add a type reference.
>
> Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> Signed-off-by: Rob Herring <[email protected]>
This is something I should have paid more attention when reviewing the
bindings. I'll try to keep it in mind for the future.
Reviewed-by: Laurent Pinchart <[email protected]>
> ---
> Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> index 289737721c2c..0b71e6f911a8 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> @@ -69,6 +69,7 @@ properties:
> maxItems: 1
>
> i2c-alias:
> + $ref: /schemas/types.yaml#/definitions/uint32
> description:
> The I2C address used for the serializer. Transactions to this
> address on the I2C bus where the deserializer resides are
--
Regards,
Laurent Pinchart
On Sun, Oct 22, 2023 at 3:17 PM Laurent Pinchart
<[email protected]> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> > Every DT property needs a type defined, but "i2c-alias" is missing any
> > type definition. It's a "uint32", so add a type reference.
> >
> > Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> > Signed-off-by: Rob Herring <[email protected]>
>
> This is something I should have paid more attention when reviewing the
> bindings. I'll try to keep it in mind for the future.
No need, the tools will check for you now. :)
But the same property defined multiple times is not yet checked
> Reviewed-by: Laurent Pinchart <[email protected]>
Thanks.
Rob
On Fri, 20 Oct 2023 12:02:24 -0500, Rob Herring wrote:
> Every DT property needs a type defined, but "i2c-alias" is missing any
> type definition. It's a "uint32", so add a type reference.
>
> Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks!