2023-10-24 14:14:52

by Jonathan Denose

Subject: [PATCH] ACPI: EC: Add quirk for HP 250 G7 Notebook PC

Added GPE quirk entry for HP 250 G7 Notebook PC. This change
allows the lid switch to be identified as the lid switch and not
a keyboard button. With the lid switch properly identified, the
device triggers suspend correctly on lid close.

Signed-off-by: Jonathan Denose <[email protected]>
---

drivers/acpi/ec.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index c95d0edb0be9e..a59c11df73754 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1924,6 +1924,16 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion Gaming Laptop 15-dk1xxx"),
},
},
+ {
+ /*
+ * HP 250 G7 Notebook PC
+ */
+ .callback = ec_honor_dsdt_gpe,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "HP"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP 250 G7 Notebook PC"),
+ },
+ },
{
/*
* Samsung hardware
--
2.42.0.758.gaed0368e0e-goog

2023-10-24 19:54:51

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI: EC: Add quirk for HP 250 G7 Notebook PC

On Tue, Oct 24, 2023 at 4:14 PM Jonathan Denose <[email protected]> wrote:
>
> Added GPE quirk entry for HP 250 G7 Notebook PC. This change
> allows the lid switch to be identified as the lid switch and not
> a keyboard button. With the lid switch properly identified, the
> device triggers suspend correctly on lid close.
>
> Signed-off-by: Jonathan Denose <[email protected]>
> ---
>
> drivers/acpi/ec.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index c95d0edb0be9e..a59c11df73754 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1924,6 +1924,16 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion Gaming Laptop 15-dk1xxx"),
> },
> },
> + {
> + /*
> + * HP 250 G7 Notebook PC
> + */
> + .callback = ec_honor_dsdt_gpe,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HP 250 G7 Notebook PC"),
> + },
> + },
> {
> /*
> * Samsung hardware
> --

Applied as 6.7 material, thanks!