2023-10-26 00:56:47

by Yang Li

Subject: [PATCH -next] fs: Remove unneeded semicolon

./fs/proc/base.c:3829:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7057
Signed-off-by: Yang Li <[email protected]>
---
fs/proc/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index bfe9547d16f9..dd31e3b6bf77 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
for_each_thread(task, pos) {
if (!nr--)
goto found;
- };
+ }
fail:
pos = NULL;
goto out;
--
2.20.1.7.g153144c

2023-10-26 15:05:58

by Oleg Nesterov

Subject: Re: [PATCH -next] fs: Remove unneeded semicolon

On 10/26, Yang Li wrote:
>
> @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
> for_each_thread(task, pos) {
> if (!nr--)
> goto found;
> - };
> + }

Ah, I forgot to remove this semicolon :/

This is on top of

document-while_each_thread-change-first_tid-to-use-for_each_thread.patch

perhaps this cleanup can be folded into the patch above along with Yang's sob ?

If Yang doesn't object.

Oleg.

2023-10-26 15:23:41

by Andrew Morton

Subject: Re: [PATCH -next] fs: Remove unneeded semicolon

On Thu, 26 Oct 2023 17:03:35 +0200 Oleg Nesterov <[email protected]> wrote:

> On 10/26, Yang Li wrote:
> >
> > @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
> > for_each_thread(task, pos) {
> > if (!nr--)
> > goto found;
> > - };
> > + }
>
> Ah, I forgot to remove this semicolon :/
>
> This is on top of
>
> document-while_each_thread-change-first_tid-to-use-for_each_thread.patch
>
> perhaps this cleanup can be folded into the patch above along with Yang's sob ?

The above is in mainline, so no squashing. I added your acked-by.