---------- Forwarded message ---------
发件人： xinglong.yang <[email protected]>
Date: 2023年11月1日周三 16:17
Subject: [PATCH] firmware: arm_scmi: Remove inappropriate error log.
To: <[email protected]>, <[email protected]>,
<[email protected]>
Cc: <[email protected]>
The platform may not support fastchannel, but this is a legal
operation.
-Before this patch, when the platform not support fastchannel,
goto err_xfer will print "Failed to ...". This log is misleading.
-With this patch, when the fastchannel is not been supported,
the "Failed to ..." log will be skipped.
Signed-off-by: xinglong.yang <[email protected]>
---
drivers/firmware/arm_scmi/driver.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/arm_scmi/driver.c
b/drivers/firmware/arm_scmi/driver.c
index b5957cc12fee..2b990e50c8a5 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -1642,7 +1642,10 @@ scmi_common_fastchannel_init(const struct
scmi_protocol_handle *ph,
* fastchannels at all.
*/
ret = ph->xops->do_xfer(ph, t);
- if (ret)
+ if (ret == -EOPNOTSUPP) {
+ ph->xops->xfer_put(ph, t);
+ goto return_normal;
+ } else if (ret)
goto err_xfer;
resp = t->rx.buf;
@@ -1695,6 +1698,7 @@ scmi_common_fastchannel_init(const struct
scmi_protocol_handle *ph,
"Using valid FC for protocol %X [MSG_ID:%u / RES_ID:%u]\n",
pi->proto->id, message_id, domain);
+return_normal:
return;
err_db_mem:
--
2.42.0
On Thu, Nov 02, 2023 at 05:55:37PM +0800, sean yang wrote:
> ---------- Forwarded message ---------
> 发件人： xinglong.yang <[email protected]>
> Date: 2023年11月1日周三 16:17
> Subject: [PATCH] firmware: arm_scmi: Remove inappropriate error log.
> To: <[email protected]>, <[email protected]>,
> <[email protected]>
> Cc: <[email protected]>
>
Same here, please avoid forwarding patches/emails on the list and wait
for couple of days to *resend*(not forward) the email/patch if you
suspect it wasn't delivered.
--
Regards,
Sudeep