2023-11-20 09:12:43

by Su Hui

Subject: [PATCH] phy: sunplus: return negative error code in sp_usb_phy_probe

devm_phy_create() return negative error code, 'ret' should be
'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'.

Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
Signed-off-by: Su Hui <[email protected]>
---
drivers/phy/sunplus/phy-sunplus-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c
index 0efe74ac9c6a..637a5fbae6d9 100644
--- a/drivers/phy/sunplus/phy-sunplus-usb2.c
+++ b/drivers/phy/sunplus/phy-sunplus-usb2.c
@@ -275,7 +275,7 @@ static int sp_usb_phy_probe(struct platform_device *pdev)

phy = devm_phy_create(&pdev->dev, NULL, &sp_uphy_ops);
if (IS_ERR(phy)) {
- ret = -PTR_ERR(phy);
+ ret = PTR_ERR(phy);
return ret;
}

--
2.30.2

2023-11-27 13:22:24

by Vinod Koul

Subject: Re: [PATCH] phy: sunplus: return negative error code in sp_usb_phy_probe

On Mon, 20 Nov 2023 17:10:47 +0800, Su Hui wrote:
> devm_phy_create() return negative error code, 'ret' should be
> 'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'.
>
>

Applied, thanks!

[1/1] phy: sunplus: return negative error code in sp_usb_phy_probe
commit: 2a9c713825b3127ece11984abf973672c9779518

Best regards,
--
~Vinod