2023-11-20 10:44:11

by Kunwu Chan

Subject: [PATCH] iommu/vt-d: Set variable intel_dirty_ops to static

Fix the followng warning:
drivers/iommu/intel/iommu.c:302:30: warning: symbol
'intel_dirty_ops' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Signed-off-by: Kunwu Chan <[email protected]>
---
drivers/iommu/intel/iommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 3531b956556c..68e4d4006300 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -299,7 +299,7 @@ static int iommu_skip_te_disable;
#define IDENTMAP_AZALIA 4

const struct iommu_ops intel_iommu_ops;
-const struct iommu_dirty_ops intel_dirty_ops;
+static const struct iommu_dirty_ops intel_dirty_ops;

static bool translation_pre_enabled(struct intel_iommu *iommu)
{
@@ -4925,7 +4925,7 @@ static int intel_iommu_read_and_clear_dirty(struct iommu_domain *domain,
return 0;
}

-const struct iommu_dirty_ops intel_dirty_ops = {
+static const struct iommu_dirty_ops intel_dirty_ops = {
.set_dirty_tracking = intel_iommu_set_dirty_tracking,
.read_and_clear_dirty = intel_iommu_read_and_clear_dirty,
};
--
2.34.1

2023-11-20 14:08:01

by Jason Gunthorpe

Subject: Re: [PATCH] iommu/vt-d: Set variable intel_dirty_ops to static

On Mon, Nov 20, 2023 at 06:10:25PM +0800, Kunwu Chan wrote:
> Fix the followng warning:
> drivers/iommu/intel/iommu.c:302:30: warning: symbol
> 'intel_dirty_ops' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Kunwu Chan <[email protected]>
> ---
> drivers/iommu/intel/iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason

2023-11-21 10:06:52

by Joao Martins

Subject: Re: [PATCH] iommu/vt-d: Set variable intel_dirty_ops to static

On 20/11/2023 10:10, Kunwu Chan wrote:
> Fix the followng warning:
> drivers/iommu/intel/iommu.c:302:30: warning: symbol
> 'intel_dirty_ops' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Kunwu Chan <[email protected]>

Reviewed-by: Joao Martins <[email protected]>

> ---
> drivers/iommu/intel/iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 3531b956556c..68e4d4006300 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -299,7 +299,7 @@ static int iommu_skip_te_disable;
> #define IDENTMAP_AZALIA 4
>
> const struct iommu_ops intel_iommu_ops;
> -const struct iommu_dirty_ops intel_dirty_ops;
> +static const struct iommu_dirty_ops intel_dirty_ops;
>
> static bool translation_pre_enabled(struct intel_iommu *iommu)
> {
> @@ -4925,7 +4925,7 @@ static int intel_iommu_read_and_clear_dirty(struct iommu_domain *domain,
> return 0;
> }
>
> -const struct iommu_dirty_ops intel_dirty_ops = {
> +static const struct iommu_dirty_ops intel_dirty_ops = {
> .set_dirty_tracking = intel_iommu_set_dirty_tracking,
> .read_and_clear_dirty = intel_iommu_read_and_clear_dirty,
> };