2023-11-21 07:09:32

by Sakari Ailus

Subject: [PATCH 1/1] ACPI: scan: Fix an error print in DisCo for Imaging support

The recently merged DisCo for Imaging support used a wrong printk
specifier in printing a message. Fix it by using %zu instead of %lu.
Also use "bits" instead of "bytes" as these are indeed bytes.

Fixes: a6cb0a611273 ("ACPI: scan: Extract MIPI DisCo for Imaging data into swnodes")
Signed-off-by: Sakari Ailus <[email protected]>
---
drivers/acpi/mipi-disco-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c
index cad72d1fc127..7286cf4579bc 100644
--- a/drivers/acpi/mipi-disco-img.c
+++ b/drivers/acpi/mipi-disco-img.c
@@ -533,7 +533,7 @@ static void init_csi2_port(struct acpi_device *adev,
if (ret < 0) {
acpi_handle_debug(handle, "Lane polarity bytes missing\n");
} else if (ret * BITS_PER_TYPE(u8) < num_lanes + 1) {
- acpi_handle_info(handle, "Too few lane polarity bytes (%lu vs. %d)\n",
+ acpi_handle_info(handle, "Too few lane polarity bits (%zu vs. %d)\n",
ret * BITS_PER_TYPE(u8), num_lanes + 1);
} else {
unsigned long mask = 0;
--
2.39.2

2023-11-21 14:13:44

by Rafael J. Wysocki

Subject: Re: [PATCH 1/1] ACPI: scan: Fix an error print in DisCo for Imaging support

On Tue, Nov 21, 2023 at 9:33 AM Sakari Ailus
<[email protected]> wrote:
>
> The recently merged DisCo for Imaging support used a wrong printk
> specifier in printing a message. Fix it by using %zu instead of %lu.
> Also use "bits" instead of "bytes" as these are indeed bytes.
>
> Fixes: a6cb0a611273 ("ACPI: scan: Extract MIPI DisCo for Imaging data into swnodes")
> Signed-off-by: Sakari Ailus <[email protected]>
> ---
> drivers/acpi/mipi-disco-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c
> index cad72d1fc127..7286cf4579bc 100644
> --- a/drivers/acpi/mipi-disco-img.c
> +++ b/drivers/acpi/mipi-disco-img.c
> @@ -533,7 +533,7 @@ static void init_csi2_port(struct acpi_device *adev,
> if (ret < 0) {
> acpi_handle_debug(handle, "Lane polarity bytes missing\n");
> } else if (ret * BITS_PER_TYPE(u8) < num_lanes + 1) {
> - acpi_handle_info(handle, "Too few lane polarity bytes (%lu vs. %d)\n",
> + acpi_handle_info(handle, "Too few lane polarity bits (%zu vs. %d)\n",
> ret * BITS_PER_TYPE(u8), num_lanes + 1);
> } else {
> unsigned long mask = 0;
> --

Applied (with a slightly adjusted subject), thanks!