2023-11-23 14:47:59

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v4 07/13] RISC-V: Move T-Head PMU to CPU feature alternative framework


> drivers/perf/riscv_pmu_sbi.c | 19 ++++++++++++++-----

> +config THEAD_CUSTOM_PMU
> + bool "T-Head custom PMU support"
> + depends on RISCV_ALTERNATIVE && RISCV_PMU_SBI
> + default y
> + help
> + The T-Head C9xx cores implement a PMU overflow extension very
> + similar to the core SSCOFPMF extension.
> +
> + This will patch the overflow CSR and handle the non-standard
> + behaviour via the regular SBI PMU driver and interface.
> +
> + If you don't know what to do here, say "Y".

This is a < 20 line diff to the pmu driver, is it really worth adding
having config options for these two non standard PMU implementations?


Attachments:
(No filename) (664.00 B)
signature.asc (235.00 B)
Download all attachments